1
0
mirror of https://github.com/golang/go synced 2024-11-17 23:14:49 -07:00
The Go programming language
Go to file
David Lazar 5d1b53a944 cmd/compile: generate code that type checks when inlining variadic functions
This fixes a bug in -l=3 or higher.

To inline a variadic function, the compiler generates code that constructs
a slice of arguments for the variadic parameter. Consider the function

  func Foo(xs ...string)

and the call Foo("hello", "world"). To inline the call to Foo, the
compiler used to generate

  xs := [2]string{"hello", "world"}[:]

which doesn't type check:

  invalid operation [2]string literal[:] (slice of unaddressable value).

Now, the compiler generates

  xs := []string{"hello", "world"}

which does type check.

Fixes #18116.

Change-Id: I0ee531ef2e6cc276db6fb12602b25a46d6d5db21
Reviewed-on: https://go-review.googlesource.com/33671
Reviewed-by: Keith Randall <khr@golang.org>
2016-11-30 19:46:00 +00:00
.github doc: improve issue template 2016-08-29 03:33:28 +00:00
api api, doc: update go1.8.txt and next.txt 2016-11-16 01:19:56 +00:00
doc doc: document default GOPATH in go1.8.html 2016-11-30 19:26:45 +00:00
lib/time lib/time: update tzdata to 2016i 2016-11-10 19:14:51 +00:00
misc runtime: fix undead arguments in cgocall 2016-11-30 17:09:17 +00:00
src cmd/compile: generate code that type checks when inlining variadic functions 2016-11-30 19:46:00 +00:00
test cmd/compile: generate code that type checks when inlining variadic functions 2016-11-30 19:46:00 +00:00
.gitattributes
.gitignore
AUTHORS A+C: update for Go 1.8 2016-11-10 19:35:02 +00:00
CONTRIBUTING.md
CONTRIBUTORS A+C: update for Go 1.8 2016-11-10 19:35:02 +00:00
favicon.ico website: recreate 16px and 32px favicon 2016-08-25 15:43:32 +00:00
LICENSE doc: revert copyright date to 2009 2016-06-01 22:40:04 +00:00
PATENTS
README.md
robots.txt

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image

For documentation about how to install and use Go, visit https://golang.org/ or load doc/install-source.html in your web browser.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Go is the work of hundreds of contributors. We appreciate your help!

To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html

Note that we do not accept pull requests and that we use the issue tracker for bug reports and proposals only. Please ask questions on https://forum.golangbridge.org or https://groups.google.com/forum/#!forum/golang-nuts.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

--

Binary Distribution Notes

If you have just untarred a binary Go distribution, you need to set the environment variable $GOROOT to the full path of the go directory (the one containing this file). You can omit the variable if you unpack it into /usr/local/go, or if you rebuild from sources by running all.bash (see doc/install-source.html). You should also add the Go binary directory $GOROOT/bin to your shell's path.

For example, if you extracted the tar file into $HOME/go, you might put the following in your .profile:

export GOROOT=$HOME/go
export PATH=$PATH:$GOROOT/bin

See https://golang.org/doc/install or doc/install.html for more details.