mirror of
https://github.com/golang/go
synced 2024-09-29 15:24:28 -06:00
9f9e17a82f
The special case logic for go/defer arguments in Escape.call was scattered around a bit and was somewhat inconsistently handled across different types of function calls and parameters. This CL pulls the logic out into a separate callStmt method that's used uniformly for all kinds of function calls and arguments. Fixes #31573. Change-Id: Icdcdf611754dc3fcf1af7cb52879fb4b73a7a31f Reviewed-on: https://go-review.googlesource.com/c/go/+/173019 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
50 lines
2.6 KiB
Go
50 lines
2.6 KiB
Go
// errorcheck -0 -m
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package p
|
|
|
|
func f(...*int) {} // ERROR "can inline f$"
|
|
|
|
func g() {
|
|
defer f() // ERROR "... argument does not escape$"
|
|
defer f(new(int)) // ERROR "... argument does not escape$" "new\(int\) does not escape$"
|
|
defer f(new(int), new(int)) // ERROR "... argument does not escape$" "new\(int\) does not escape$"
|
|
|
|
defer f(nil...)
|
|
defer f([]*int{}...) // ERROR "\[\]\*int literal does not escape$"
|
|
defer f([]*int{new(int)}...) // ERROR "\[\]\*int literal does not escape$" "new\(int\) does not escape$"
|
|
defer f([]*int{new(int), new(int)}...) // ERROR "\[\]\*int literal does not escape$" "new\(int\) does not escape$"
|
|
|
|
go f() // ERROR "... argument escapes to heap$"
|
|
go f(new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
go f(new(int), new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
|
|
go f(nil...)
|
|
go f([]*int{}...) // ERROR "\[\]\*int literal escapes to heap$"
|
|
go f([]*int{new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
go f([]*int{new(int), new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
|
|
for {
|
|
defer f() // ERROR "... argument escapes to heap$"
|
|
defer f(new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
defer f(new(int), new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
|
|
defer f(nil...)
|
|
defer f([]*int{}...) // ERROR "\[\]\*int literal escapes to heap$"
|
|
defer f([]*int{new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
defer f([]*int{new(int), new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
|
|
go f() // ERROR "... argument escapes to heap$"
|
|
go f(new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
go f(new(int), new(int)) // ERROR "... argument escapes to heap$" "new\(int\) escapes to heap$"
|
|
|
|
go f(nil...)
|
|
go f([]*int{}...) // ERROR "\[\]\*int literal escapes to heap$"
|
|
go f([]*int{new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
go f([]*int{new(int), new(int)}...) // ERROR "\[\]\*int literal escapes to heap$" "new\(int\) escapes to heap$"
|
|
}
|
|
}
|