mirror of
https://github.com/golang/go
synced 2024-11-22 04:04:40 -07:00
56e0ecc5ea
Keep track of how many uses each Value has. Each appearance in Value.Args and in Block.Control counts once. The number of uses of a value is generically useful to constrain rewrite rules. For instance, we might want to prevent merging index operations into loads if the same index expression is used lots of times. But I have one use in particular for which the use count is required. We must make sure we don't combine ops with loads if the load has more than one use. Otherwise, we may split a single load into multiple loads and that breaks perceived behavior in the presence of races. In particular, the load of m.state in sync/mutex.go:Lock can't be done twice. (I have a separate CL which triggers the mutex failure. This CL has a test which demonstrates a similar failure.) Change-Id: Icaafa479239f48632a069d0c3f624e6ebc6b1f0e Reviewed-on: https://go-review.googlesource.com/20790 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Todd Neal <todd@tneal.org>
46 lines
798 B
Go
46 lines
798 B
Go
// run
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Check that we do loads exactly once. The SSA backend
|
|
// once tried to do the load in f twice, once sign extended
|
|
// and once zero extended. This can cause problems in
|
|
// racy code, particularly sync/mutex.
|
|
|
|
package main
|
|
|
|
func f(p *byte) bool {
|
|
x := *p
|
|
a := int64(int8(x))
|
|
b := int64(uint8(x))
|
|
return a == b
|
|
}
|
|
|
|
func main() {
|
|
var x byte
|
|
const N = 1000000
|
|
c := make(chan struct{})
|
|
go func() {
|
|
for i := 0; i < N; i++ {
|
|
x = 1
|
|
}
|
|
c <- struct{}{}
|
|
}()
|
|
go func() {
|
|
for i := 0; i < N; i++ {
|
|
x = 2
|
|
}
|
|
c <- struct{}{}
|
|
}()
|
|
|
|
for i := 0; i < N; i++ {
|
|
if !f(&x) {
|
|
panic("non-atomic load!")
|
|
}
|
|
}
|
|
<-c
|
|
<-c
|
|
}
|