mirror of
https://github.com/golang/go
synced 2024-11-22 20:40:03 -07:00
2e457b3868
Previously, the unified frontend implemented unsafe.Sizeof, etc that involved derived types by constructing a normal OSIZEOF, etc expression, including fully instantiating their argument. (When unsafe.Sizeof is applied to a non-generic type, types2 handles constant folding it.) This worked, but involves unnecessary work, since all we really need to track is the argument type (and the field selections, for unsafe.Offsetof). Further, the argument expression could generate temporary variables, which would then go unused after typecheck replaced the OSIZEOF expression with an OLITERAL. This results in compiler failures after CL 523315, which made later passes stricter about expecting the frontend to not construct unused temporaries. Fixes #62515. Change-Id: I37baed048fd2e35648c59243f66c97c24413aa94 Reviewed-on: https://go-review.googlesource.com/c/go/+/527097 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Auto-Submit: Matthew Dempsky <mdempsky@google.com>
28 lines
592 B
Go
28 lines
592 B
Go
// compile
|
|
|
|
// Copyright 2023 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Unified frontend generated unnecessary temporaries for expressions
|
|
// within unsafe.Sizeof, etc functions.
|
|
|
|
package main
|
|
|
|
import "unsafe"
|
|
|
|
func F[G int](g G) (uintptr, uintptr, uintptr) {
|
|
var c chan func() int
|
|
type s struct {
|
|
g G
|
|
x []int
|
|
}
|
|
return unsafe.Sizeof(s{g, make([]int, (<-c)())}),
|
|
unsafe.Alignof(s{g, make([]int, (<-c)())}),
|
|
unsafe.Offsetof(s{g, make([]int, (<-c)())}.x)
|
|
}
|
|
|
|
func main() {
|
|
F(0)
|
|
}
|