5bf6c97e76
The existing implementation of `load.resolveEmbed` uses an expression like `path[len(pkgdir)+1:]`. Though the `+1` is intended to remove a prefix slash, the expression returns an incorrect path when `pkgdir` is "/". (ex.: when removing "/" from "/foo", want "foo", but got "oo") It seems that `str.TrimFilePathPrefix` would solve the problem, but the function contains the same bug. So, this commit fixes `str.TrimFilePathPrefix` then applies it to `load.resolveEmbed` to solve the issue. The fix is quite simple. First, remove prefix. Then check whether the remained first letter is equal to `filepath.Separator`. If so, remove it then return. Fixed #49570 Change-Id: I26ab727ee4dfcbf51ed9bd0a573957ced2154515 Reviewed-on: https://go-review.googlesource.com/c/go/+/396694 Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.