1
0
mirror of https://github.com/golang/go synced 2024-09-30 16:28:32 -06:00
go/internal/lsp
Muir Manders 5bf02b21f1 internal/lsp/source: fix bug in deep completion score tracking
We keep track of the N highest seen scores so we can quickly skip deep
completions not in the top N. Our logic for maintaining the top N list
wasn't quite right, resulting in certain cases where we would let
non-high scoring candidates through. I don't think the bug impacted
correctness.

Change-Id: Ic105617523c82f0e71e4f95ef0ee216182a84252
Reviewed-on: https://go-review.googlesource.com/c/tools/+/247418
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-08-08 16:17:06 +00:00
..
analysis internal/lsp: prioritize non-"zero" values in fillreturns 2020-08-07 14:33:55 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
cmd internal: add call hierarchy cmd and lsp scaffolding 2020-08-07 20:22:52 +00:00
debug internal/lsp: separate LSP files from FS files 2020-08-03 22:16:06 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp: remove uses of crypto/sha1 in gopls 2020-07-28 22:26:17 +00:00
mod internal/lsp: separate LSP files from FS files 2020-08-03 22:16:06 +00:00
protocol internal/lsp/protocol/typescript: clean up type gen documentation 2020-08-08 14:55:51 +00:00
regtest internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: fix bug in deep completion score tracking 2020-08-08 16:17:06 +00:00
testdata internal/lsp/source: improve type switch case completion 2020-08-07 23:56:57 +00:00
tests internal: add call hierarchy cmd and lsp scaffolding 2020-08-07 20:22:52 +00:00
call_hierarchy.go internal/lsp: release resources for call hierarchy file requests 2020-08-07 21:04:51 +00:00
code_action.go internal/lsp: fix bug in extract variable edit positions 2020-08-04 20:55:55 +00:00
code_lens.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
command.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
definition.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
diagnostics.go internal/lsp: separate LSP files from FS files 2020-08-03 22:16:06 +00:00
folding_range.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
format.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
general.go internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
highlight.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
hover.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
implementation.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
link.go internal/lsp: remove source.Cache 2020-08-05 22:08:24 +00:00
lsp_test.go internal: add call hierarchy cmd and lsp scaffolding 2020-08-07 20:22:52 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
rename.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go internal: add call hierarchy cmd and lsp scaffolding 2020-08-07 20:22:52 +00:00
server.go internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
signature_help.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
symbols.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
text_synchronization.go internal/lsp: watch directories in replace targets and update on changes 2020-08-07 23:35:17 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00