mirror of
https://github.com/golang/go
synced 2024-11-18 22:04:43 -07:00
2b6af5f9ac
Added a check to make sure that highlighting the control flow of a function only continues if the cursor is actually in a function. Change-Id: Idac90d9e55c09c3dcb9ae938585157658acc95e9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/209581 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
270 lines
7.6 KiB
Go
270 lines
7.6 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package source
|
|
|
|
import (
|
|
"context"
|
|
"go/ast"
|
|
"go/token"
|
|
|
|
"golang.org/x/tools/go/ast/astutil"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
"golang.org/x/tools/internal/telemetry/trace"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
func Highlight(ctx context.Context, snapshot Snapshot, f File, pos protocol.Position) ([]protocol.Range, error) {
|
|
ctx, done := trace.StartSpan(ctx, "source.Highlight")
|
|
defer done()
|
|
|
|
fh := snapshot.Handle(ctx, f)
|
|
phs, err := snapshot.PackageHandles(ctx, fh)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ph, err := WidestCheckPackageHandle(phs)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pkg, err := ph.Check(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pgh, err := pkg.File(f.URI())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
file, m, _, err := pgh.Parse(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
spn, err := m.PointSpan(pos)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rng, err := spn.Range(m.Converter)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
path, _ := astutil.PathEnclosingInterval(file, rng.Start, rng.Start)
|
|
if len(path) == 0 {
|
|
return nil, errors.Errorf("no enclosing position found for %v:%v", int(pos.Line), int(pos.Character))
|
|
}
|
|
switch path[0].(type) {
|
|
case *ast.ReturnStmt, *ast.FuncDecl, *ast.FuncType, *ast.BasicLit:
|
|
return highlightFuncControlFlow(ctx, snapshot, m, path)
|
|
case *ast.Ident:
|
|
return highlightIdentifiers(ctx, snapshot, m, path, pkg)
|
|
case *ast.BranchStmt, *ast.ForStmt, *ast.RangeStmt:
|
|
return highlightLoopControlFlow(ctx, snapshot, m, path)
|
|
}
|
|
// If the cursor is in an unidentified area, return empty results.
|
|
return nil, nil
|
|
}
|
|
|
|
func highlightFuncControlFlow(ctx context.Context, snapshot Snapshot, m *protocol.ColumnMapper, path []ast.Node) ([]protocol.Range, error) {
|
|
var enclosingFunc ast.Node
|
|
var returnStmt *ast.ReturnStmt
|
|
var resultsList *ast.FieldList
|
|
inReturnList := false
|
|
Outer:
|
|
// Reverse walk the path till we get to the func block.
|
|
for _, n := range path {
|
|
switch node := n.(type) {
|
|
case *ast.Field:
|
|
inReturnList = true
|
|
case *ast.FuncLit:
|
|
enclosingFunc = n
|
|
resultsList = node.Type.Results
|
|
break Outer
|
|
case *ast.FuncDecl:
|
|
enclosingFunc = n
|
|
resultsList = node.Type.Results
|
|
break Outer
|
|
case *ast.ReturnStmt:
|
|
returnStmt = node
|
|
// If the cursor is not directly in a *ast.ReturnStmt, then
|
|
// we need to know if it is within one of the values that is being returned.
|
|
inReturnList = inReturnList || path[0] != returnStmt
|
|
}
|
|
}
|
|
// Cursor is not in a function.
|
|
if enclosingFunc == nil {
|
|
return nil, nil
|
|
}
|
|
// If the cursor is on a "return" or "func" keyword, we should highlight all of the exit
|
|
// points of the function, including the "return" and "func" keywords.
|
|
highlightAllReturnsAndFunc := path[0] == returnStmt || path[0] == enclosingFunc
|
|
switch path[0].(type) {
|
|
case *ast.Ident, *ast.BasicLit:
|
|
// Cursor is in an identifier and not in a return statement or in the results list.
|
|
if returnStmt == nil && !inReturnList {
|
|
return nil, nil
|
|
}
|
|
case *ast.FuncType:
|
|
highlightAllReturnsAndFunc = true
|
|
}
|
|
// The user's cursor may be within the return statement of a function,
|
|
// or within the result section of a function's signature.
|
|
// index := -1
|
|
var nodes []ast.Node
|
|
if returnStmt != nil {
|
|
for _, n := range returnStmt.Results {
|
|
nodes = append(nodes, n)
|
|
}
|
|
} else if resultsList != nil {
|
|
for _, n := range resultsList.List {
|
|
nodes = append(nodes, n)
|
|
}
|
|
}
|
|
_, index := nodeAtPos(nodes, path[0].Pos())
|
|
|
|
result := make(map[protocol.Range]bool)
|
|
// Highlight the correct argument in the function declaration return types.
|
|
if resultsList != nil && -1 < index && index < len(resultsList.List) {
|
|
rng, err := nodeToProtocolRange(ctx, snapshot.View(), m, resultsList.List[index])
|
|
if err != nil {
|
|
log.Error(ctx, "Error getting range for node", err)
|
|
} else {
|
|
result[rng] = true
|
|
}
|
|
}
|
|
// Add the "func" part of the func declaration.
|
|
if highlightAllReturnsAndFunc {
|
|
funcStmt, err := posToRange(snapshot.View(), m, enclosingFunc.Pos(), enclosingFunc.Pos()+token.Pos(len("func")))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rng, err := funcStmt.Range()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
result[rng] = true
|
|
}
|
|
// Traverse the AST to highlight the other relevant return statements in the function.
|
|
ast.Inspect(enclosingFunc, func(n ast.Node) bool {
|
|
// Don't traverse any other functions.
|
|
switch n.(type) {
|
|
case *ast.FuncDecl, *ast.FuncLit:
|
|
return enclosingFunc == n
|
|
}
|
|
if n, ok := n.(*ast.ReturnStmt); ok {
|
|
var toAdd ast.Node
|
|
// Add the entire return statement, applies when highlight the word "return" or "func".
|
|
if highlightAllReturnsAndFunc {
|
|
toAdd = n
|
|
}
|
|
// Add the relevant field within the entire return statement.
|
|
if -1 < index && index < len(n.Results) {
|
|
toAdd = n.Results[index]
|
|
}
|
|
if toAdd != nil {
|
|
rng, err := nodeToProtocolRange(ctx, snapshot.View(), m, toAdd)
|
|
if err != nil {
|
|
log.Error(ctx, "Error getting range for node", err)
|
|
} else {
|
|
result[rng] = true
|
|
}
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
})
|
|
return rangeMapToSlice(result), nil
|
|
}
|
|
|
|
func highlightLoopControlFlow(ctx context.Context, snapshot Snapshot, m *protocol.ColumnMapper, path []ast.Node) ([]protocol.Range, error) {
|
|
var loop ast.Node
|
|
Outer:
|
|
// Reverse walk the path till we get to the for loop.
|
|
for _, n := range path {
|
|
switch n.(type) {
|
|
case *ast.ForStmt, *ast.RangeStmt:
|
|
loop = n
|
|
break Outer
|
|
}
|
|
}
|
|
// Cursor is not in a for loop.
|
|
if loop == nil {
|
|
return nil, nil
|
|
}
|
|
result := make(map[protocol.Range]bool)
|
|
// Add the for statement.
|
|
forStmt, err := posToRange(snapshot.View(), m, loop.Pos(), loop.Pos()+token.Pos(len("for")))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rng, err := forStmt.Range()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
result[rng] = true
|
|
|
|
ast.Inspect(loop, func(n ast.Node) bool {
|
|
// Don't traverse any other for loops.
|
|
switch n.(type) {
|
|
case *ast.ForStmt, *ast.RangeStmt:
|
|
return loop == n
|
|
}
|
|
// Add all branch statements in same scope as the identified one.
|
|
if n, ok := n.(*ast.BranchStmt); ok {
|
|
rng, err := nodeToProtocolRange(ctx, snapshot.View(), m, n)
|
|
if err != nil {
|
|
log.Error(ctx, "Error getting range for node", err)
|
|
return false
|
|
}
|
|
result[rng] = true
|
|
}
|
|
return true
|
|
})
|
|
return rangeMapToSlice(result), nil
|
|
}
|
|
|
|
func highlightIdentifiers(ctx context.Context, snapshot Snapshot, m *protocol.ColumnMapper, path []ast.Node, pkg Package) ([]protocol.Range, error) {
|
|
result := make(map[protocol.Range]bool)
|
|
id, ok := path[0].(*ast.Ident)
|
|
if !ok {
|
|
return nil, errors.Errorf("highlightIdentifiers called with an ast.Node of type %T", id)
|
|
}
|
|
// Check if ident is inside return or func decl.
|
|
if toAdd, err := highlightFuncControlFlow(ctx, snapshot, m, path); toAdd != nil && err == nil {
|
|
for _, r := range toAdd {
|
|
result[r] = true
|
|
}
|
|
}
|
|
|
|
// TODO: maybe check if ident is a reserved word, if true then don't continue and return results.
|
|
|
|
idObj := pkg.GetTypesInfo().ObjectOf(id)
|
|
ast.Inspect(path[len(path)-1], func(node ast.Node) bool {
|
|
n, ok := node.(*ast.Ident)
|
|
if !ok {
|
|
return true
|
|
}
|
|
if n.Name != id.Name || n.Obj != id.Obj {
|
|
return false
|
|
}
|
|
if nObj := pkg.GetTypesInfo().ObjectOf(n); nObj != idObj {
|
|
return false
|
|
}
|
|
if rng, err := nodeToProtocolRange(ctx, snapshot.View(), m, n); err == nil {
|
|
result[rng] = true
|
|
} else {
|
|
log.Error(ctx, "Error getting range for node", err)
|
|
}
|
|
return false
|
|
})
|
|
return rangeMapToSlice(result), nil
|
|
}
|
|
|
|
func rangeMapToSlice(rangeMap map[protocol.Range]bool) []protocol.Range {
|
|
var list []protocol.Range
|
|
for i := range rangeMap {
|
|
list = append(list, i)
|
|
}
|
|
return list
|
|
}
|