Muir Manders 5a76f03bc7 internal/lsp: fix variadic interface completion ranking ... In cases like: var foo []io.Writer var buf *bytes.Buffer foo = append(foo, <>) we weren't giving "buf" a good score. When comparing the candidate type *bytes.Buffer to the (variadic) expected type []io.Writer we were turning the candidate type into []*bytes.Buffer. However, of course, []*bytes.Buffer is not assignable to []io.Writer, so the types didn't match. Now we instead turn the expected type []io.Writer into io.Writer and compare to *bytes.Buffer. I fixed the @rank test note to check that the candidates' scores are strictly decreasing. Previously it would allow candidates with the same score if they happened to be in the right order. This made it easier to right a test for this issue, but also uncovered an issue with untyped completion logic. I fixed it to do the untyped constant check if _either_ the expected or candidate type is untyped (previously it required the candidate type to be untyped). Fixes golang/go#35625. Change-Id: I9a837d6a781669cb7a2f1d6d3d7f360c85be49eb Reviewed-on: https://go-review.googlesource.com/c/tools/+/207518 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-11-18 05:14:29 +00:00
..
completion.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
diagnostics.go	internal/lsp: use the AST to get correct ranges	2019-10-22 16:21:03 +00:00
links.go	tools/gopls: add command line support for links	2019-11-01 17:18:15 +00:00
tests.go	tools/gopls: add cmd support for folding_ranges	2019-11-12 00:55:09 +00:00