Muir Manders 5a76f03bc7 internal/lsp: fix variadic interface completion ranking ... In cases like: var foo []io.Writer var buf *bytes.Buffer foo = append(foo, <>) we weren't giving "buf" a good score. When comparing the candidate type *bytes.Buffer to the (variadic) expected type []io.Writer we were turning the candidate type into []*bytes.Buffer. However, of course, []*bytes.Buffer is not assignable to []io.Writer, so the types didn't match. Now we instead turn the expected type []io.Writer into io.Writer and compare to *bytes.Buffer. I fixed the @rank test note to check that the candidates' scores are strictly decreasing. Previously it would allow candidates with the same score if they happened to be in the right order. This made it easier to right a test for this issue, but also uncovered an issue with untyped completion logic. I fixed it to do the untyped constant check if _either_ the expected or candidate type is untyped (previously it required the candidate type to be untyped). Fixes golang/go#35625. Change-Id: I9a837d6a781669cb7a2f1d6d3d7f360c85be49eb Reviewed-on: https://go-review.googlesource.com/c/tools/+/207518 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-11-18 05:14:29 +00:00
..
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion_format.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
completion_keywords.go	internal/lsp: add some keyword completions	2019-10-22 20:49:18 +00:00
completion_labels.go	internal/lsp: fix label completion in range and type switch stmts	2019-10-22 21:33:09 +00:00
completion_literal.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
completion_snippet.go	internal/lsp: don't overwrite suffix when inserting completion	2019-10-02 20:07:45 +00:00
completion.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
deep_completion.go	internal/lsp/source: attach Package to completions when available	2019-11-05 20:21:09 +00:00
diagnostics.go	internal/lsp: use versioned URIs in rename and code actions	2019-11-13 05:52:40 +00:00
errors.go	internal/lsp: move the missing imports handling into the metadata	2019-09-25 23:05:17 +00:00
folding_range.go	internal/lsp: rework snapshots and cache FileHandles per-snapshot	2019-10-01 16:26:22 +00:00
format.go	internal/lsp: ignore AST errors when generating import edits	2019-11-14 22:23:41 +00:00
highlight.go	internal/lsp: stop cluttering logs with highlight errors	2019-10-07 17:20:23 +00:00
hover.go	internal/lsp: don't associate package with snapshot	2019-10-23 20:24:04 +00:00
identifier.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
implementation.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
options.go	internal/lsp: add config flag to hide debugging output	2019-11-05 20:43:22 +00:00
references.go	internal/lsp/source: add support for references in the same workspace	2019-11-14 20:04:27 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
rename.go	internal/lsp: use versioned URIs in rename and code actions	2019-11-13 05:52:40 +00:00
signature_help.go	internal/lsp: remove the pkg.view field, in preparation for CL 204079	2019-10-29 23:14:01 +00:00
source_test.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
suggested_fix.go	internal/lsp: move error range computations into cache package	2019-10-21 22:12:58 +00:00
symbols.go	internal/lsp: stop caching diagnostics on the package	2019-10-24 22:03:59 +00:00
tidy.go	internal/lsp: support running go mod tidy as a code action	2019-09-20 13:08:46 +00:00
util.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
view.go	internal/lsp: fix panic in bestView	2019-11-16 21:44:31 +00:00