5a2161ce9e
The GoSyscallBegin event is a signal for both the P and the G to enter a syscall state for the trace parser. (Ps can't have their own event because it's too hard to model. As soon as the P enters _Psyscall it can get stolen out of it.) But there's a window in time between when that event is emitted and when the P enters _Psyscall where the P's status can get emitted. In this window the tracer will emit the wrong status: Running instead of Syscall. Really any call into the tracer could emit a status event for the P, but in this particular case it's when running a safepoint function that explicitly emits an event for the P's status. The fix is straightforward. The source-of-truth on syscall status is the G's status, so the function that emits the P's status just needs to check the status of any G attached to it. If it's in _Gsyscall, then the tracer should emit a Syscall status for the P if it's in _Prunning. Fixes #64318. Change-Id: I3b0fb0d41ff578e62810b04fa5a3ef73e2929b0a Reviewed-on: https://go-review.googlesource.com/c/go/+/546025 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.