Muir Manders 59228eac51 internal/lsp: avoid invalid state due to context cancelation ... In shouldRunGopackages we would reset a goFile's metadata and pkgs in advance of re-running go/packages. However, if we did not end up running go/packages for whatever reason (read: we got canceled), the goFile gets stuck in the unfortunate state of not belonging to any packages because "pkgs" is empty. I think this leads to "no CheckPackageHandle" errors, at least in relation to GetCachedPackage() calls. Fix by deferring the reset of goFile's metadata and pkgs until after the go/packages call has succeeded. Change-Id: I95aace85c026e1232b42cadee9e7772951c817d0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/193601 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-09-05 23:06:12 +00:00
..
apidiff	all: skip tests if required tools are not found	2019-08-30 15:40:57 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	internal/imports: skip scanned module cache dirs	2019-08-29 21:03:13 +00:00
imports	internal/imports: ignore invalid mod cache entries	2019-09-05 17:34:53 +00:00
jsonrpc2	internal/lsp: use a background context for the background worker	2019-07-18 19:01:55 +00:00
lsp	internal/lsp: avoid invalid state due to context cancelation	2019-09-05 23:06:12 +00:00
memoize	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: handle character values beyond end of line in FromUTF16Column	2019-07-06 07:08:13 +00:00
telemetry	internal/lsp: add additional information when logging errors	2019-08-26 18:41:59 +00:00
testenv	all: skip more memory-intensive tests on linux-arm	2019-08-30 17:05:41 +00:00
tool	internal/tool: add a small package to unify the flag handling across all our tools	2018-12-17 23:08:00 +00:00
txtar	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00