1
0
mirror of https://github.com/golang/go synced 2024-11-19 00:34:40 -07:00
go/src
Matthew Dempsky 581526ce96 cmd/compile: rewrite untyped constant conversion logic
This CL detangles the hairy mess that was convlit+defaultlit. In
particular, it makes the following changes:

1. convlit1 now follows the standard typecheck behavior of setting
"n.Type = nil" if there's an error. Notably, this means for a lot of
test cases, we now avoid reporting useless follow-on error messages.
For example, after reporting that "1 << s + 1.0" has an invalid shift,
we no longer also report that it can't be assigned to string.

2. Previously, assignconvfn had some extra logic for trying to
suppress errors from convlit/defaultlit so that it could provide its
own errors with better context information. Instead, this extra
context information is now passed down into convlit1 directly.

3. Relatedly, this CL also removes redundant calls to defaultlit prior
to assignconv. As a consequence, when an expression doesn't make sense
for a particular assignment (e.g., assigning an untyped string to an
integer), the error messages now say "untyped string" instead of just
"string". This is more consistent with go/types behavior.

4. defaultlit2 is now smarter about only trying to convert pairs of
untyped constants when it's likely to succeed. This allows us to
report better error messages for things like 3+"x"; instead of "cannot
convert 3 to string" we now report "mismatched types untyped number
and untyped string".

Passes toolstash-check.

Change-Id: I26822a02dc35855bd0ac774907b1cf5737e91882
Reviewed-on: https://go-review.googlesource.com/c/go/+/187657
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2019-09-06 23:15:48 +00:00
..
archive archive/zip: remove unused special case 2019-08-27 17:00:43 +00:00
bufio bufio: fix ExampleScanner_Bytes comment, add error check 2019-06-25 00:29:24 +00:00
builtin
bytes bytes/hash: disable seed test on 32-bit platforms 2019-09-03 19:37:16 +00:00
cmd cmd/compile: rewrite untyped constant conversion logic 2019-09-06 23:15:48 +00:00
compress compress/flate: improve deflate performance by register allocating the index 2019-08-28 12:48:37 +00:00
container
context all: remove os.ErrTimeout 2019-08-02 17:57:18 +00:00
crypto crypto/x509: remove IsCA exception for broken Entrust root 2019-09-03 21:10:31 +00:00
database/sql std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
debug debug/dwarf: better handling for DW_FORM_indirect 2019-09-03 18:35:32 +00:00
encoding std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
errors errors: clarify docs for when As returns false 2019-09-06 00:03:32 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt doc/go1.13: document fmt's number syntax updates 2019-08-23 23:40:29 +00:00
go cmd/doc: make -src mode deterministic 2019-09-02 15:31:19 +00:00
hash
html html/template: micro optimization for isJSType 2019-08-27 17:41:33 +00:00
image image/png: hoist repetitive pixels per byte out of loop in Encode 2019-08-28 09:02:35 +00:00
index/suffixarray
internal std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
io io/ioutil: don't check for short write in WriteFile 2019-09-01 02:31:50 +00:00
log
math math/big: fix a duplicate "the" in a comment 2019-09-02 11:42:47 +00:00
mime mime: update type of .js and .mjs files to text/javascript 2019-09-01 10:08:53 +00:00
net net: document concurrency safety and example for Dialer 2019-09-02 14:47:38 +00:00
os std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
path path: change the output format of ExampleSplit function 2019-09-01 10:08:36 +00:00
plugin plugin: add freebsd/amd64 plugin support 2019-09-03 14:27:24 +00:00
reflect cmd/compile,runtime: generate hash functions only for types which are map keys 2019-09-03 20:41:29 +00:00
regexp regexp: add example for ReplaceAll 2019-09-05 23:52:39 +00:00
runtime runtime: use hard heap goal if we've done more scan work than expected 2019-09-04 21:52:18 +00:00
sort
strconv strconv: Speed improvement to number parsing 2019-08-28 03:23:59 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync sync: document implementation of Once.Do 2019-07-01 14:45:49 +00:00
syscall syscall: redirect writes to runtime.write in faketime mode 2019-09-04 17:56:17 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/template: refer to sorted map keys as "ordered" not "comparable" in docs 2019-09-06 21:22:26 +00:00
time time: update TestSub to avoid future regressions 2019-08-16 19:54:57 +00:00
unicode
unsafe
vendor net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
go.sum net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
README.vendor all: update 'go get' command in standard library README.vendor 2019-08-23 21:07:49 +00:00
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.