Austin Clements 79561a84ce runtime: simplify reflectcall write barriers ... Currently reflectcall has a subtle dance with write barriers where the assembly code copies the result values from the stack to the in-heap argument frame without write barriers and then calls into the runtime after the fact to invoke the necessary write barriers. For the hybrid barrier (and for ROC), we need to switch to a *pre*-write write barrier, which is very difficult to do with the current setup. We could tie ourselves in knots of subtle reasoning about why it's okay in this particular case to have a post-write write barrier, but this commit instead takes a different approach. Rather than making things more complex, this simplifies reflection calls so that the argument copy is done in Go using normal bulk write barriers. The one difficulty with this approach is that calling into Go requires putting arguments on the stack, but the call* functions "donate" their entire stack frame to the called function. We can get away with this now because the copy avoids using the stack and has copied the results out before we clobber the stack frame to call into the write barrier. The solution in this CL is to call another function, passing arguments in registers instead of on the stack, and let that other function reserve more stack space and setup the arguments for the runtime. This approach seemed to work out the best. I also tried making the call* functions reserve 32 extra bytes of frame for the write barrier arguments and adjust SP up by 32 bytes around the call. However, even with the necessary changes to the assembler to correct the spdelta table, the runtime was still having trouble with the frame layout (and the changes to the assembler caused many other things that do strange things with the SP to fail to assemble). The approach I took doesn't require any funny business with the SP. Updates #17503. Change-Id: Ie2bb0084b24d6cff38b5afb218b9e0534ad2119e Reviewed-on: https://go-review.googlesource.com/31655 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com>		2016-10-26 15:44:44 +00:00
..
all_test.go	all: minor vet fixes	2016-10-24 17:27:37 +00:00
asm_386.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_amd64.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_amd64p32.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_arm64.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_arm.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_mips64x.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_ppc64x.s	all: make copyright headers consistent with one space after period	2016-03-01 23:34:33 +00:00
asm_s390x.s	reflect: add s390x support	2016-04-06 04:23:06 +00:00
deepequal.go	reflect: fix DeepEqual for some cyclic corner cases	2016-10-24 15:20:23 +00:00
example_test.go	reflect: add method StructTag.Lookup	2016-03-25 04:54:19 +00:00
export_test.go	runtime: tell race detector about reflectOffs.lock	2016-05-26 14:43:27 +00:00
makefunc.go	runtime: fix getArgInfo for deferred reflection calls	2016-10-17 18:57:01 +00:00
set_test.go	reflect: recognize unnamed directional channels	2016-03-04 20:34:30 +00:00
swapper.go	reflect: add Swapper func	2016-09-30 20:26:54 +00:00
tostring_test.go
type.go	reflect: update FieldByNameFunc comment	2016-10-19 13:32:51 +00:00
value.go	runtime: simplify reflectcall write barriers	2016-10-26 15:44:44 +00:00