54efef99b2
Currently TestPull is flaky because goroutines spawned to run subtests exit asynchronously when they finish and TestPull has explicit checks for the number of existing goroutines. This is pretty much only a problem between subtests executing, because within each subtest the coroutine goroutine spawned for iter.Pull always exits fully synchronously before the final `next` or `stop` returns. So, we can resolve the problem by ensuring the first goroutine count the test takes likely doesn't contain any exiting goroutines. The trick is to set GOMAXPROCS=1 and spin in runtime.Gosched until the number of goroutines stabilizes to some reasonable degree (we pick 100 consecutive iterations; there are only a handful of possible goroutines that can run, so this is giving that handful around 20 chances to actually run to completion). When running TestPull under stress2, this issue is easily reproducible before this CL. After this CL, it no longer reproduces under these conditions. Fixes #66017. Change-Id: I4bf0a9771f7364df7dd58f8aeb3ae26742d5746f Reviewed-on: https://go-review.googlesource.com/c/go/+/587917 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.