1
0
mirror of https://github.com/golang/go synced 2024-11-18 08:54:45 -07:00
go/internal
Rob Findley 5298e130f1 internal/lsp: lift up workdone instrumentation to didModifyFiles
Previously, workdone reporting was managed by the goroutine(s) that
compute diagnostics following a file change. The intention was to signal
when diagnostics resulting from file changes were complete.

This was buggy, in two ways:
 + When no snapshots are determined to require diagnosis, no work is
   reported.
 + If multiple snapshots required diagnosis, we'd get multiple work IDs.

Fix this by lifting up the 'work' to the level of didModifyFiles.

Change-Id: I73cf8bf9946dba777650bba9d4d18dad6954620e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/235738
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-03 13:18:45 +00:00
..
analysisinternal internal/lsp: add goreturns like functionality as quickfix 2020-04-01 19:27:44 +00:00
apidiff
event internal/event: improve the logging of events 2020-05-11 17:49:55 +00:00
fakenet internal/fakenet: add a fake network connection 2020-05-27 14:27:59 +00:00
fastwalk internal/fastwalk: attempt Symlink tests on Windows 2020-05-21 21:19:27 +00:00
gocommand internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
gopathwalk internal: rationalize debug logging 2020-03-03 16:59:18 +00:00
imports all: remove version-specific test files 2020-05-28 17:13:50 +00:00
jsonrpc2 internal/lsp: change exit handling 2020-06-03 13:14:19 +00:00
lsp internal/lsp: lift up workdone instrumentation to didModifyFiles 2020-06-03 13:18:45 +00:00
memoize internal/lsp/debug: serve cache entry counts 2020-02-03 22:21:18 +00:00
packagesinternal go/packages: add a Module field to the Package struct 2020-05-19 14:27:18 +00:00
proxydir all: remove version-specific test files 2020-05-28 17:13:50 +00:00
span internal/span: handle URI escaping better 2020-02-18 20:59:02 +00:00
stack internal/stack: add the leak test 2020-05-27 14:25:42 +00:00
testenv all: replace build tags in tests with testenv helper 2020-05-27 18:32:53 +00:00
tool internal/tool: avoid editorialization 2020-03-05 14:01:59 +00:00
xcontext