1
0
mirror of https://github.com/golang/go synced 2024-11-18 22:55:23 -07:00
The Go programming language
Go to file
Heschi Kreinick 520188d60f go/packages: fix flaky failure creating non-test package from overlay
The core of processGolistOverlay was a map iteration, which is
nondeterministic. When creating both a non-test and test package, we
would sometimes encounter the test file before the non-test file. In
that case, for reasons I didn't bother tracking down, we would never
create the non-test package.

Rather than doing complicated bookkeeping to fix the problem, simply
process non-test before test, and make the loop deterministic to save
all of our sanity.

Updates golang/go#36661.

Change-Id: I1f76869fa52794ac8ae96e22ad06a2b1e1861995
Reviewed-on: https://go-review.googlesource.com/c/tools/+/216717
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-01-28 22:03:07 +00:00
benchmark/parse benchmark/parse: add unit test for String function 2019-12-16 21:43:19 +00:00
blog blog: fix swallowed error 2019-12-18 19:17:56 +00:00
cmd cmd/stress: use an ellipsis when truncating output 2020-01-22 22:00:14 +00:00
container/intsets
cover cover: error on negative numbers in profiles 2020-01-15 21:23:19 +00:00
go go/packages: fix flaky failure creating non-test package from overlay 2020-01-28 22:03:07 +00:00
godoc godoc/static: update copyright year to 2013 2020-01-02 16:51:58 +00:00
gopls gopls/doc: document updating to an unstable version 2020-01-25 22:37:03 +00:00
imports imports: pass more of the environment 2019-12-17 00:36:01 +00:00
internal internal/lsp: recover from a view initialization failure 2020-01-28 22:02:46 +00:00
playground playground/socket: handle multi-file present play snippets 2019-12-03 04:46:16 +00:00
present all: remove many cases of space-space 2019-12-30 19:07:42 +00:00
refactor all: fix more typos 2019-09-11 15:13:14 +00:00
txtar txtar/archive: add unit test function for Format 2019-11-20 20:49:00 +00:00
.gitattributes
.gitignore
AUTHORS
codereview.cfg
CONTRIBUTING.md
CONTRIBUTORS
go.mod internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
go.sum internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
LICENSE
PATENTS
README.md

Go Tools

This subrepository holds the source for various packages and tools that support the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.

Others, including the Go guru and the test coverage tool, can be fetched with go get.

Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.

Download/Install

The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.