1
0
mirror of https://github.com/golang/go synced 2024-11-18 21:05:02 -07:00
go/internal/lsp/cache
Heschi Kreinick 50c778fb86 internal/imports: redesign scan API
We have multiple use cases for scanning: goimports, import completion,
and unimported completions. All three need slightly different features,
and the latter have very different performance considerations. Scanning
everything all at once and returning it was not good enough for them.

Instead, design the API as a series of callbacks for each
directory/package: first we discover its existence, then we load its
package name, then we load its exports. At each step the caller can
choose whether to proceed with the package. Import completion can stop
before loading exports, goimports can apply its directory name
heuristics, and in the future we'll be able to stop the scan short once
we've found all the results we want for completions.

I don't intend any significant changes here but there may be some little
ones around the edges.

Change-Id: I39c3aa08cc0e4793c280242c342770f62e101364
Reviewed-on: https://go-review.googlesource.com/c/tools/+/212631
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-30 21:10:22 +00:00
..
analysis.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
builtin.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
cache.go internal/lsp: return snapshots from text modifications 2019-12-18 22:53:40 +00:00
check.go internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
debug.go internal/lsp: don't clear file contents on save 2019-12-19 23:08:27 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
external.go internal/lsp: use versioned URIs in rename and code actions 2019-11-13 05:52:40 +00:00
file.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
load.go internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
modfiles.go internal/lsp: change -modfile flag to tempModfile 2019-12-20 19:10:06 +00:00
overlay.go internal/lsp: don't clear file contents on save 2019-12-19 23:08:27 +00:00
parse_mod.go internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
parse.go internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
pkg.go internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
session.go internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
snapshot.go internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
view.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00