1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:54:42 -07:00
go/internal/imports
Heschi Kreinick 50c778fb86 internal/imports: redesign scan API
We have multiple use cases for scanning: goimports, import completion,
and unimported completions. All three need slightly different features,
and the latter have very different performance considerations. Scanning
everything all at once and returning it was not good enough for them.

Instead, design the API as a series of callbacks for each
directory/package: first we discover its existence, then we load its
package name, then we load its exports. At each step the caller can
choose whether to proceed with the package. Import completion can stop
before loading exports, goimports can apply its directory name
heuristics, and in the future we'll be able to stop the scan short once
we've found all the results we want for completions.

I don't intend any significant changes here but there may be some little
ones around the edges.

Change-Id: I39c3aa08cc0e4793c280242c342770f62e101364
Reviewed-on: https://go-review.googlesource.com/c/tools/+/212631
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-30 21:10:22 +00:00
..
testdata/mod imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
fix_test.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
fix.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
imports_test.go internal/lsp/source: optimize computeFixEdits 2019-12-06 20:21:26 +00:00
imports.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
mkindex.go imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
mkstdlib.go internal/imports: cache GOPATH, exports 2019-11-04 21:31:17 +00:00
mod_112_test.go imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
mod_114_test.go internal/imports: support vendoring in module mode 2019-10-24 21:04:39 +00:00
mod_cache_test.go internal/imports: cache GOPATH, exports 2019-11-04 21:31:17 +00:00
mod_cache.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
mod_pre114_test.go internal/imports: support vendoring in module mode 2019-10-24 21:04:39 +00:00
mod_test.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
mod.go internal/imports: redesign scan API 2019-12-30 21:10:22 +00:00
proxy_112_test.go imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
proxy_113_test.go imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
sortimports.go internal/imports: merge import declarations 2019-08-14 23:54:02 +00:00
zstdlib.go internal/imports: cache GOPATH, exports 2019-11-04 21:31:17 +00:00