pjw 5091d647ee internal/lsp: reorganize the generated Go code for the lsp protocol ... Code generation has been unified, so that tsprotocol.go and tsserver.go are produced by the same program. tsprotocol.go is about 900 lines shorter, partly from removing boilerplate comments that golint no longer requires. (And partly by generating fewer unneeded types.) The choice made for a union type is commented with the set of types. There is no Go equivalent for union types, but making themn all interface{} would replace type checking at unmarshalling with checking runtime conversions. Intersection types (A&B) are sometimes embedded (struct{A;B;}, and sometimes expanded, as they have to be if A and B have fields with the same names. There are fewer embedded structs, which had been verbose and confusing to initialize. They have been replaced by types whose names end in Gn. Essentially all the generated *structs have been removed. This makes no difference in what the client sends, and the server may send a {} where it previously might have sent nothing. The benefit is that some nil tests can be removed. Thus 'omitempty' in json tags is just documentation that the element is optional in the protocol. The files that generate this code will be submitted later, but soon. Change-Id: I52b997d9c58de3d733fc8c6ce061e47ce2bdb100 Reviewed-on: https://go-review.googlesource.com/c/tools/+/207598 Run-TryBot: Peter Weinberger <pjw@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>		2019-11-18 19:51:19 +00:00
..
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion_format.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
completion_keywords.go	internal/lsp: add some keyword completions	2019-10-22 20:49:18 +00:00
completion_labels.go	internal/lsp: fix label completion in range and type switch stmts	2019-10-22 21:33:09 +00:00
completion_literal.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
completion_snippet.go	internal/lsp: don't overwrite suffix when inserting completion	2019-10-02 20:07:45 +00:00
completion.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
deep_completion.go	internal/lsp/source: attach Package to completions when available	2019-11-05 20:21:09 +00:00
diagnostics.go	internal/lsp: use versioned URIs in rename and code actions	2019-11-13 05:52:40 +00:00
errors.go	internal/lsp: move the missing imports handling into the metadata	2019-09-25 23:05:17 +00:00
folding_range.go	internal/lsp: rework snapshots and cache FileHandles per-snapshot	2019-10-01 16:26:22 +00:00
format.go	internal/lsp: ignore AST errors when generating import edits	2019-11-14 22:23:41 +00:00
highlight.go	internal/lsp: stop cluttering logs with highlight errors	2019-10-07 17:20:23 +00:00
hover.go	internal/lsp: don't associate package with snapshot	2019-10-23 20:24:04 +00:00
identifier.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
implementation.go	internal/lsp: look up files in packages by position instead of URI	2019-11-13 16:34:02 +00:00
options.go	internal/lsp: reorganize the generated Go code for the lsp protocol	2019-11-18 19:51:19 +00:00
references.go	internal/lsp/source: add support for references in the same workspace	2019-11-14 20:04:27 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
rename.go	internal/lsp: use versioned URIs in rename and code actions	2019-11-13 05:52:40 +00:00
signature_help.go	internal/lsp: remove the pkg.view field, in preparation for CL 204079	2019-10-29 23:14:01 +00:00
source_test.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
suggested_fix.go	internal/lsp: move error range computations into cache package	2019-10-21 22:12:58 +00:00
symbols.go	internal/lsp: stop caching diagnostics on the package	2019-10-24 22:03:59 +00:00
tidy.go	internal/lsp: support running go mod tidy as a code action	2019-09-20 13:08:46 +00:00
util.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
view.go	internal/lsp: fix panic in bestView	2019-11-16 21:44:31 +00:00