mirror of
https://github.com/golang/go
synced 2024-11-08 19:46:23 -07:00
9d669ed47a
The test was using the wrong column numbers, and was erroneously passing because there happened to be line numbers that matched those column numbers. Change the test harness to require the expected line number for the ERROR HERE regexp case, so that this doesn't happen again. Also rename a couple of variables in the test to avoid useless redeclaration errors. Fixes #46534 Change-Id: I2fcbf5e379c346de5346035c73d174a3980c0927 Reviewed-on: https://go-review.googlesource.com/c/go/+/324970 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
159 lines
3.4 KiB
Go
159 lines
3.4 KiB
Go
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package errorstest
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func path(file string) string {
|
|
return filepath.Join("testdata", file)
|
|
}
|
|
|
|
func check(t *testing.T, file string) {
|
|
t.Run(file, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
contents, err := os.ReadFile(path(file))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var errors []*regexp.Regexp
|
|
for i, line := range bytes.Split(contents, []byte("\n")) {
|
|
if bytes.HasSuffix(line, []byte("ERROR HERE")) {
|
|
re := regexp.MustCompile(regexp.QuoteMeta(fmt.Sprintf("%s:%d:", file, i+1)))
|
|
errors = append(errors, re)
|
|
continue
|
|
}
|
|
|
|
frags := bytes.SplitAfterN(line, []byte("ERROR HERE: "), 2)
|
|
if len(frags) == 1 {
|
|
continue
|
|
}
|
|
frag := fmt.Sprintf(":%d:.*%s", i+1, frags[1])
|
|
re, err := regexp.Compile(frag)
|
|
if err != nil {
|
|
t.Errorf("Invalid regexp after `ERROR HERE: `: %#q", frags[1])
|
|
continue
|
|
}
|
|
errors = append(errors, re)
|
|
}
|
|
if len(errors) == 0 {
|
|
t.Fatalf("cannot find ERROR HERE")
|
|
}
|
|
expect(t, file, errors)
|
|
})
|
|
}
|
|
|
|
func expect(t *testing.T, file string, errors []*regexp.Regexp) {
|
|
dir, err := os.MkdirTemp("", filepath.Base(t.Name()))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dir)
|
|
|
|
dst := filepath.Join(dir, strings.TrimSuffix(file, ".go"))
|
|
cmd := exec.Command("go", "build", "-gcflags=-L -e", "-o="+dst, path(file)) // TODO(gri) no need for -gcflags=-L if go tool is adjusted
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
t.Errorf("expected cgo to fail but it succeeded")
|
|
}
|
|
|
|
lines := bytes.Split(out, []byte("\n"))
|
|
for _, re := range errors {
|
|
found := false
|
|
for _, line := range lines {
|
|
if re.Match(line) {
|
|
t.Logf("found match for %#q: %q", re, line)
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
if !found {
|
|
t.Errorf("expected error output to contain %#q", re)
|
|
}
|
|
}
|
|
|
|
if t.Failed() {
|
|
t.Logf("actual output:\n%s", out)
|
|
}
|
|
}
|
|
|
|
func sizeofLongDouble(t *testing.T) int {
|
|
cmd := exec.Command("go", "run", path("long_double_size.go"))
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("%#q: %v:\n%s", strings.Join(cmd.Args, " "), err, out)
|
|
}
|
|
|
|
i, err := strconv.Atoi(strings.TrimSpace(string(out)))
|
|
if err != nil {
|
|
t.Fatalf("long_double_size.go printed invalid size: %s", out)
|
|
}
|
|
return i
|
|
}
|
|
|
|
func TestReportsTypeErrors(t *testing.T) {
|
|
for _, file := range []string{
|
|
"err1.go",
|
|
"err2.go",
|
|
"issue11097a.go",
|
|
"issue11097b.go",
|
|
"issue18452.go",
|
|
"issue18889.go",
|
|
"issue28721.go",
|
|
"issue33061.go",
|
|
} {
|
|
check(t, file)
|
|
}
|
|
|
|
if sizeofLongDouble(t) > 8 {
|
|
for _, file := range []string{
|
|
"err4.go",
|
|
"issue28069.go",
|
|
} {
|
|
check(t, file)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestToleratesOptimizationFlag(t *testing.T) {
|
|
for _, cflags := range []string{
|
|
"",
|
|
"-O",
|
|
} {
|
|
cflags := cflags
|
|
t.Run(cflags, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cmd := exec.Command("go", "build", path("issue14669.go"))
|
|
cmd.Env = append(os.Environ(), "CGO_CFLAGS="+cflags)
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Errorf("%#q: %v:\n%s", strings.Join(cmd.Args, " "), err, out)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestMallocCrashesOnNil(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cmd := exec.Command("go", "run", path("malloc.go"))
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
t.Logf("%#q:\n%s", strings.Join(cmd.Args, " "), out)
|
|
t.Fatalf("succeeded unexpectedly")
|
|
}
|
|
}
|