mirror of
https://github.com/golang/go
synced 2024-11-17 01:54:53 -07:00
4f915911e8
The alias doesn't need to be marked go:notinheap. It gets its notinheap-ness from the target type. Without this change, the type alias test in the notinheap.go file generates these two errors: notinheap.go:62: misplaced compiler directive notinheap.go:63: type nih must be go:notinheap The first is a result of go:notinheap pragmas not applying to type alias declarations. The second is the result of then trying to match the notinheap-ness of the alias and the target type. Add a few more go:notinheap tests while we are here. Update #40954 Change-Id: I067ec47698df6e9e593e080d67796fd05a1d480f Reviewed-on: https://go-review.googlesource.com/c/go/+/250939 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Trust: Keith Randall <khr@golang.org>
72 lines
1.6 KiB
Go
72 lines
1.6 KiB
Go
// errorcheck -+
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test type-checking errors for go:notinheap.
|
|
|
|
package p
|
|
|
|
//go:notinheap
|
|
type nih struct{}
|
|
|
|
// Types embedding notinheap types must be notinheap.
|
|
|
|
type embed1 struct { // ERROR "must be go:notinheap"
|
|
x nih
|
|
}
|
|
|
|
type embed2 [1]nih // ERROR "must be go:notinheap"
|
|
|
|
type embed3 struct { // ERROR "must be go:notinheap"
|
|
x [1]nih
|
|
}
|
|
|
|
type embed4 map[nih]int // ERROR "go:notinheap map key not allowed"
|
|
|
|
type embed5 map[int]nih // ERROR "go:notinheap map value not allowed"
|
|
|
|
type emebd6 chan nih // ERROR "chan of go:notinheap type not allowed"
|
|
|
|
type okay1 *nih
|
|
|
|
type okay2 []nih
|
|
|
|
type okay3 func(x nih) nih
|
|
|
|
type okay4 interface {
|
|
f(x nih) nih
|
|
}
|
|
|
|
// Type conversions don't let you sneak past notinheap.
|
|
|
|
type t1 struct{ x int }
|
|
|
|
//go:notinheap
|
|
type t2 t1
|
|
|
|
//go:notinheap
|
|
type t3 byte
|
|
|
|
//go:notinheap
|
|
type t4 rune
|
|
|
|
// Type aliases inherit the go:notinheap-ness of the type they alias.
|
|
type nihAlias = nih
|
|
|
|
type embedAlias1 struct { // ERROR "must be go:notinheap"
|
|
x nihAlias
|
|
}
|
|
type embedAlias2 [1]nihAlias // ERROR "must be go:notinheap"
|
|
|
|
var sink interface{}
|
|
|
|
func i() {
|
|
sink = new(t1) // no error
|
|
sink = (*t2)(new(t1)) // ERROR "cannot convert(.|\n)*t2 is go:notinheap"
|
|
sink = (*t2)(new(struct{ x int })) // ERROR "cannot convert(.|\n)*t2 is go:notinheap"
|
|
sink = []t3("foo") // ERROR "cannot convert(.|\n)*t3 is go:notinheap"
|
|
sink = []t4("bar") // ERROR "cannot convert(.|\n)*t4 is go:notinheap"
|
|
}
|