mirror of
https://github.com/golang/go
synced 2024-11-18 22:55:23 -07:00
ed30b9180d
The go/packages workaround to hide errors for overlay packages doesn't seem to work well. It's easier to just hide list errors in gopls diagnostics unless the package genuinely failed to type-check. Check if the package has missing dependencies as an approximation of if it is well-typed. This required some additional special casing for the import cycle error detection, which now causes them to have duplicate diagnostics. It's a rare enough case that this doesn't concern me, but we should clean this up at some point. Fixes golang/go#36754. Change-Id: If12c92fb9a0e0b69b711ae9a509ecb1b2a32255c Reviewed-on: https://go-review.googlesource.com/c/tools/+/216310 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> |
||
|---|---|---|
| .. | ||
| address | ||
| analyzer | ||
| anon | ||
| append | ||
| arraytype | ||
| assign | ||
| bad | ||
| badstmt | ||
| bar | ||
| basiclit | ||
| baz | ||
| builtins | ||
| casesensitive | ||
| cast | ||
| cgo | ||
| cgoimport | ||
| channel | ||
| circular | ||
| comments | ||
| complit | ||
| constant | ||
| deep | ||
| errors | ||
| fieldlist | ||
| folding | ||
| foo | ||
| format | ||
| func_rank | ||
| funcsig | ||
| funcvalue | ||
| fuzzymatch | ||
| generated | ||
| godef | ||
| good | ||
| highlights | ||
| implementation | ||
| importedcomplit | ||
| imports | ||
| index | ||
| interfacerank | ||
| keywords | ||
| labels | ||
| links | ||
| maps | ||
| nested_complit | ||
| nodisk | ||
| noparse | ||
| noparse_format | ||
| rank | ||
| references | ||
| rename | ||
| selector | ||
| signature | ||
| snippets | ||
| suggestedfix | ||
| symbols | ||
| testy | ||
| typeassert | ||
| types | ||
| unimported | ||
| unresolved | ||
| unsafe | ||
| variadic | ||
| summary.txt.golden | ||