mirror of
https://github.com/golang/go
synced 2024-11-27 00:01:23 -07:00
a4b95cd092
We lost a sign extension that was necessary. The nonnegative comparison didn't have the correct extension on it. If the larger constant is positive, but its shorter sign extension is negative, the rule breaks. Fixes #41872 Change-Id: I6592ef103f840fbb786bf8cb94fd8804c760c976 Reviewed-on: https://go-review.googlesource.com/c/go/+/260701 Trust: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
27 lines
443 B
Go
27 lines
443 B
Go
// run
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved. Use of this
|
|
// source code is governed by a BSD-style license that can be found in
|
|
// the LICENSE file.
|
|
|
|
package main
|
|
|
|
//go:noinline
|
|
func f8(x int32) bool {
|
|
return byte(x&0xc0) == 64
|
|
}
|
|
|
|
//go:noinline
|
|
func f16(x int32) bool {
|
|
return uint16(x&0x8040) == 64
|
|
}
|
|
|
|
func main() {
|
|
if !f8(64) {
|
|
panic("wanted true, got false")
|
|
}
|
|
if !f16(64) {
|
|
panic("wanted true, got false")
|
|
}
|
|
}
|