Rebecca Stambler 4d14fc9c00 internal/lsp: add type error fixes to existing diagnostics ... This change is the first step in handling golang/go#38136. Instead of creating multiple diagnostic reports for type error analyzers, we add suggested fixes to the existing reports. To match the analyzers for FindAnalysisError, we add an ErrorMatch function to source.Analyzer. This is not an ideal solution, but it was the best one I could come up with without modifying the go/analysis API. analysisinternal could be used for this purpose, but it seemed to complicated to be worth it, and this is fairly simple. I think that go/analysis itself might need to be extended for type error analyzers, but these temporary measures will help us understand the kinds of features we need for type error analyzers. A follow-up CL might be to not add reports for type error analyzers until the end of source.Diagnostic, which would remove the need for the look-up. Fixes golang/go#38136 Change-Id: I25bc6396b09d49facecd918bf5591d2d5bdf1b3a Reviewed-on: https://go-review.googlesource.com/c/tools/+/226777 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-04-08 01:45:16 +00:00
..
code_lens.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_format.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer completion "if err != nil { return err }"	2020-03-10 21:06:53 +00:00
completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/lsp: refactor and propagate errors from code actions	2020-03-31 20:20:46 +00:00
highlight.go	internal/lsp: avoid logging context cancellation	2020-03-31 01:46:33 +00:00
hover.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
identifier.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
implementation.go	internal/lsp: fix references for transitive dependencies	2020-04-02 20:53:30 +00:00
options.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
references.go	internal/lsp, go/packages: don't log context cancellation errors	2020-04-03 19:08:13 +00:00
rename_check.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
rename.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
signature_help.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
source_test.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
symbols.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
util.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
view.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
workspace_symbol.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00