1
0
mirror of https://github.com/golang/go synced 2024-11-16 22:04:50 -07:00
go/src
Michael Anthony Knyszek 4c943abb95 runtime: fix comments on the behavior of SetGCPercent
Fixes for #49680, #49695, #45867, and #49370 all assumed that
SetGCPercent(-1) doesn't block until the GC's mark phase is done, but
it actually does. The cause of 3 of those 4 failures comes from the fact
that at the beginning of the sweep phase, the GC does try to preempt
every P once, and this may run concurrently with test code. In the
fourth case, the issue was likely that only *one* of the debug_test.go
tests was missing a call to SetGCPercent(-1). Just to be safe, leave a
TODO there for now to remove the extraneous runtime.GC calls, but leave
the calls in.

Updates #49680, #49695, #45867, and #49370.

Change-Id: Ibf4e64addfba18312526968bcf40f1f5d54eb3f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/369815
Reviewed-by: Austin Clements <austin@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2021-12-07 17:46:04 +00:00
..
archive
bufio bufio: mention that panic at slicing means underlying reader is broken 2021-11-26 22:36:21 +00:00
builtin builtin: document "any" and "comparable" 2021-12-03 01:09:21 +00:00
bytes
cmd cmd/go: fix tests broken in CL 358539 2021-12-07 03:44:02 +00:00
compress
constraints
container
context
crypto crypto/x509: fix comments on certDirectories 2021-12-02 22:53:18 +00:00
database/sql
debug cmd/go: adjust BuildInfo.Settings 2021-11-30 18:09:02 +00:00
embed
encoding
errors
expvar
flag
fmt
go go/types, types2: unexport NewTypeList 2021-12-06 14:58:33 +00:00
hash
html
image
index/suffixarray
internal runtime: break out new minimum heap size into a goexperiment 2021-12-02 18:02:46 +00:00
io
log log/syslog: create unix sockets in unique directories 2021-12-06 22:35:32 +00:00
math
mime
net net: in (*netFD).dial, use the passed in local address if getsockname fails 2021-12-07 02:31:12 +00:00
os os: test that LookupEnv reports all keys found in Environ 2021-12-03 14:28:11 +00:00
path
plugin
reflect
regexp
runtime runtime: fix comments on the behavior of SetGCPercent 2021-12-07 17:46:04 +00:00
sort sort: improve sort documentation 2021-11-16 23:13:41 +00:00
strconv
strings
sync sync: in TryLock try to acquire mutex even if state is not 0 2021-11-16 05:58:03 +00:00
syscall
testdata
testing testing: simplify fuzzResult.String to avoid unnecessarily using fmt.Sprintf 2021-11-27 23:25:39 +00:00
text
time
unicode
unsafe
vendor all: update vendored golang.org/x/sys 2021-12-06 14:32:58 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored golang.org/x/sys 2021-12-06 14:32:58 +00:00
go.sum all: update vendored golang.org/x/sys 2021-12-06 14:32:58 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.