1
0
mirror of https://github.com/golang/go synced 2024-09-29 14:24:32 -06:00
go/misc/cgo
Ian Lance Taylor 4b3a3bd3aa runtime: don't issue cgocheck error for timer bucket source pointer
The cgo checker was issuing an error with cgocheck=2 when a timer
bucket was stored in a pollDesc. The pollDesc values are allocated
using persistentalloc, so they are not in the Go heap. The code is OK
since timer bucket pointers point into a global array, and as such are
never garbage collected or moved.

Mark timersBucket notinheap to avoid the problem. timersBucket values
only occur in the global timers array.

Fixes #23435

Change-Id: I835f31caafd54cdacc692db5989de63bb49e7697
Reviewed-on: https://go-review.googlesource.com/87637
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-01-15 22:18:55 +00:00
..
errors runtime: don't issue cgocheck error for timer bucket source pointer 2018-01-15 22:18:55 +00:00
fortran *.bash: always use the same string equality operator 2017-03-14 21:46:31 +00:00
gmp
life test/run: use go tool compile + link instead of go run when possible 2017-10-31 13:21:05 +00:00
nocgo
stdio test/run: use go tool compile + link instead of go run when possible 2017-10-31 13:21:05 +00:00
test misc/cgo/test: avoid endless loop when we can't parse notes 2018-01-11 19:55:49 +00:00
testasan
testcarchive cmd/go: correct buildmode test (from "c-header" to "c-shared") 2018-01-11 19:24:35 +00:00
testcshared cmd/go: correct buildmode test (from "c-header" to "c-shared") 2018-01-11 19:24:35 +00:00
testgodefs
testplugin misc/cgo/testplugin: unskip test 2017-12-06 18:57:07 +00:00
testsanitizers all: use Fatalf instead of Fatal if format is given 2018-01-10 01:35:45 +00:00
testshared cmd/go: make gccgo -buildmode=shared and -linkshared work again 2018-01-12 05:25:55 +00:00
testsigfwd
testso
testsovar
testtls