Heschi Kreinick cf5ba95194 internal/imports: stop leaking listeners ... (*dirInfoCache).ScanAndListen saves a listener when it's called. That listener is a chain of callbacks that leads all the way back up to the original caller, i.e. the gopls completion code. It needs to unregister that listener, but in cases where the context was cancelled before it finished its initial walk of the cache, it failed to. In gopls' case, that means retaining the entire state of the workspace as of completion triggering. Return a real stop function on all paths. Change-Id: Iff3046e627b1fa89f576371c4742fee6fdca7589 Reviewed-on: https://go-review.googlesource.com/c/tools/+/217677 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-02-04 05:47:48 +00:00
..
testdata/mod	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
fix_test.go	all: fix some staticcheck errors	2020-01-29 04:53:41 +00:00
fix.go	internal/lsp/source: score in-memory unimported candidates	2020-01-17 01:23:04 +00:00
imports_test.go	internal/lsp/source: optimize computeFixEdits	2019-12-06 20:21:26 +00:00
imports.go	internal/imports: pass dummy source for completion functions	2020-01-21 20:03:11 +00:00
mkindex.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
mkstdlib.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
mod_112_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
mod_114_test.go	internal/imports: support vendoring in module mode	2019-10-24 21:04:39 +00:00
mod_cache_test.go	internal/imports: clean up dead code	2019-12-30 21:21:44 +00:00
mod_cache.go	internal/imports: stop leaking listeners	2020-02-04 05:47:48 +00:00
mod_pre114_test.go	internal/imports: support vendoring in module mode	2019-10-24 21:04:39 +00:00
mod_test.go	internal/lsp/source: score in-memory unimported candidates	2020-01-17 01:23:04 +00:00
mod.go	internal/lsp/cache: let gopls track go.mod files	2020-01-17 21:20:11 +00:00
proxy_112_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
proxy_113_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
sortimports.go	internal/imports: merge import declarations	2019-08-14 23:54:02 +00:00
zstdlib.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00