1
0
mirror of https://github.com/golang/go synced 2024-10-01 10:38:33 -06:00
go/dashboard/builder
Brad Fitzpatrick 305a363bdd dashboard/builder: fix bugs
1) Killing proceses on timeout was wrong: the os/exec
package will never return our package's error type
from its Wait.

2) fix a goroutine leak on timeout.

3) unexported an undocumented and elsewhere-unused type.

4) rename timeout type to end in "Error", per convention,
not Err.

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/74290043
2014-03-11 18:13:26 -07:00
..
doc.go go.tools: add dashboard 2013-08-01 13:23:51 +10:00
env.go go.tools/dashboard/builder: always cross compile for nacl builds 2014-03-12 09:52:02 +11:00
exec.go dashboard/builder: fix bugs 2014-03-11 18:13:26 -07:00
http.go dashboard/builder: minor fixes and enhancements 2013-11-22 10:12:51 +04:00
main.go go.tools/dashboard/builder: Use git for gccgo builds instead of svn. 2014-02-19 16:32:41 -08:00
Makefile go.tools: add dashboard 2013-08-01 13:23:51 +10:00
vcs.go go.tools/dashboard/builder: use "hg archive -t files -r REV dest" instead of "hg clone" for the work directory. 2014-02-13 20:50:29 -05:00