mirror of
https://github.com/golang/go
synced 2024-09-30 22:58:34 -06:00
49ba83114e
When the value of a composite literal key/value pair was unparsable,
you were getting completions for the composite literal keys instead of
values. For example "struct { foo int }{foo: []<>" was completing to
the field name "foo". This was because the leaf ast.Node at the cursor
was the composite literal itself, and our go-back-one-character logic
was not happening because the preceding character's node
was *ast.BadExpr, not *ast.Ident. Fix by always generating the ast
path for the character before the cursor's position. I couldn't find
any cases where this broke completion.
I also added expected type detection for the following composite
literal cases:
- array/slice literals
- struct literals (both implicit and explicit field names)
- map keys and values
Fixes golang/go#29153
Change-Id: If8cf678cbd743a970f52893fcf4a9b83ea06d7e9
GitHub-Last-Rev: f385705cc05eb98132e20561451dbb8c39b68519
GitHub-Pull-Request: golang/tools#86
Reviewed-on: https://go-review.googlesource.com/c/tools/+/173099
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
|
||
|---|---|---|
| .. | ||
| analyzer | ||
| anon | ||
| bad | ||
| bar | ||
| baz | ||
| builtins | ||
| cast | ||
| complit | ||
| errors | ||
| foo | ||
| format | ||
| func_rank | ||
| godef | ||
| good | ||
| highlights | ||
| nested_complit | ||
| nodisk | ||
| noparse | ||
| noparse_format | ||
| rank | ||
| selector | ||
| signature | ||
| stringlit | ||
| symbols | ||
| testy | ||
| types | ||