Heschi Kreinick 4981f6b3ad internal/lsp/cache: consolidate snapshot cloning ... Cloning is complicated enough without worrying about concurrency, so hold the snapshot's lock during the entire process. Consolidate everything into one function. I don't think that the split was making it easier to understand, and I was able to see and clean up some extra complexity once it was all in one place. Let's discuss options if you think the result is too long. I don't intend any semantic changes in this CL. Updates golang/go#35638. Change-Id: I05c4b28875976293f5fcd56248d9c9e468f85cc6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/211537 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-12-16 21:51:44 +00:00
..
apidiff	all: fix more typos	2019-09-11 15:13:14 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	internal/gopathwalk/walk: add missing function descriptions and renaming	2019-12-16 21:45:07 +00:00
imports	internal/lsp/source: optimize computeFixEdits	2019-12-06 20:21:26 +00:00
jsonrpc2	internal/lsp: cancel early	2019-10-22 07:49:31 +00:00
lsp	internal/lsp/cache: consolidate snapshot cloning	2019-12-16 21:51:44 +00:00
memoize	internal/memoize: fix race on read of handle.function	2019-12-05 18:38:34 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: support line directives	2019-11-25 19:20:43 +00:00
telemetry	internal/telemetry: lift the tests up to the request level	2019-11-27 15:41:43 +00:00
testenv	internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT	2019-11-11 19:22:22 +00:00
tool	internal/lsp, internal/tool: clean up command line of gopls	2019-12-16 17:36:52 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00