Muir Manders 49797d04a8 internal/lsp/source: improve completion in type assertions ... In cases like: var foo *someType = bar.(some<>) We will now complete "some" to "*someType". This involved two changes: 1. Properly detect expected type as *someType in above example. To do this I just removed *ast.TypeAssertExpr from breaksExpectedTypeInference() so we continue searching up the AST for the expected type. 2. If the given type name T doesn't match, also try *T. If *T does match, we mark the candidate as "makePointer=true" so we know to prepend the "*" when formatting the candidate. Change-Id: I05859c68082a798141755b614673a1483d864e3e Reviewed-on: https://go-review.googlesource.com/c/tools/+/212717 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-01-16 01:06:23 +00:00
..
address	internal/lsp: trim address operator from completion filterText	2019-12-24 05:57:32 +00:00
analyzer	go/analysis: rename reportNodef to ReportRangef	2019-10-28 19:16:33 +00:00
anon	internal/lsp: add additional tests for completion	2018-12-19 22:27:14 +00:00
append	internal/lsp: improve completion in append() calls	2019-11-09 21:27:01 +00:00
arraytype	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
assign	internal/lsp/source: improve completion in value spec	2019-12-23 21:16:02 +00:00
bad	internal/lsp/source: fix all types in resolveInvalid	2019-12-11 23:00:51 +00:00
badstmt	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
bar	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
basiclit	internal/lsp: suppress more completions in comments and literals	2019-04-24 20:52:08 +00:00
baz	internal/lsp: search candidate type's package for completions	2019-10-30 06:26:58 +00:00
builtins	internal/lsp/source: improve completion support for args to builtins	2020-01-14 05:24:53 +00:00
casesensitive	internal/lsp: provide option for case sensitive completion	2019-09-26 16:59:42 +00:00
cast	internal/lsp: add more testdata for completion and diagnostics	2018-11-20 06:06:34 +00:00
cgo	internal/lsp/tests: skip cgo tests when not supported	2019-11-25 21:54:41 +00:00
cgoimport	internal/lsp: improve link in documentation on hover	2019-12-12 22:39:21 +00:00
channel	internal/lsp: support taking address for completion candidates	2019-12-23 23:54:10 +00:00
circular	internal/lsp: add diagnostic on import causing import cycle	2019-12-13 19:54:01 +00:00
comments	internal/lsp: suppress more completions in comments and literals	2019-04-24 20:52:08 +00:00
complit	internal/lsp: add comment completions for exported vars	2019-12-10 22:11:41 +00:00
constant	internal/lsp: remove constant value from label and add tests	2019-05-15 19:19:14 +00:00
deep	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
errors	internal/lsp: match completions case-insensitively	2019-06-28 03:43:36 +00:00
fieldlist	internal/lsp: improve completions in *ast.FieldList	2019-09-25 22:58:16 +00:00
folding	tools/gopls: add cmd support for folding_ranges	2019-11-12 00:55:09 +00:00
foo	internal/lsp: fix bad *ast.ArrayTypes for completion	2019-10-17 20:53:01 +00:00
format	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
func_rank	internal/lsp/source: improve completion in type assertions	2020-01-16 01:06:23 +00:00
funcsig	internal/lsp: fix scope of FuncType completion candidates	2019-09-25 19:53:33 +00:00
funcvalue	internal/lsp: move function signature into detail instead of label	2019-07-03 21:07:46 +00:00
fuzzymatch	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
generated	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
godef	internal/lsp: show comments for grouped variable declarations	2019-12-18 20:39:36 +00:00
good	internal/lsp: remove duplicated enums	2019-09-25 15:30:23 +00:00
highlights	internal/lsp: fix highlighting of inexact matches when highlighting from the right	2019-12-19 19:05:06 +00:00
implementation	internal/lsp: refactor find-implementation handling	2019-12-23 22:59:19 +00:00
importedcomplit	internal/lsp: fix composite literal completion	2019-05-13 22:24:33 +00:00
imports	internal/lsp/source: start import diffs at byte 0	2019-11-08 19:30:12 +00:00
index	internal/lsp: handle more expected type cases	2019-05-16 16:26:11 +00:00
interfacerank	internal/lsp: apply type modifiers to completion candidate	2019-06-19 20:27:14 +00:00
keywords	internal/lsp: suggest "fallthrough" only inside switches	2019-12-10 22:10:49 +00:00
labels	internal/lsp: fix label completion in range and type switch stmts	2019-10-22 21:33:09 +00:00
links	internal/lsp: create links for golang/go#1234-style strings	2019-12-27 05:39:25 +00:00
maps	internal/lsp/source: improve completion in type assertions	2020-01-16 01:06:23 +00:00
nested_complit	internal/lsp: improve completion for *ast.ArrayTypes	2019-10-23 16:34:50 +00:00
nodisk	internal/lsp: fix race condition in metadata handling	2019-11-04 20:35:57 +00:00
noparse	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
noparse_format	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
rank	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
references	internal/lsp/source: add support for references in the same workspace	2019-11-14 20:04:27 +00:00
rename	internal/lsp/testadata/rename: add a test case for renames across packages	2019-11-14 22:24:11 +00:00
selector	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
signature	tools/gopls: add cmd support for signature	2019-10-31 22:07:37 +00:00
snippets	internal/lsp/source: fix some invalid literal candidates	2020-01-08 20:36:44 +00:00
suggestedfix	internal/lsp: enable suggested fixes by default	2019-09-09 19:40:07 +00:00
symbols	tools/gopls: add cmd support for symbols	2019-11-01 17:43:07 +00:00
testy	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
typeassert	internal/lsp/source: improve completion in type assertions	2020-01-16 01:06:23 +00:00
types	internal/lsp: add more testdata for completion and diagnostics	2018-11-20 06:06:34 +00:00
unimported	internal/imports: load test exports of package under test	2020-01-14 23:54:10 +00:00
unresolved	internal/lsp: fix function value completions	2019-06-20 15:43:39 +00:00
unsafe	internal/lsp: fix type checking for unsafe package	2019-06-11 19:41:53 +00:00
variadic	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
summary.txt.golden	internal/lsp/source: improve completion in type assertions	2020-01-16 01:06:23 +00:00