1
0
mirror of https://github.com/golang/go synced 2024-11-13 13:30:24 -07:00
go/src
Jelle van den Hooff 48dbb6227a runtime: set raceignore to zero when starting a new goroutine
When reusing a g struct the runtime did not reset
g.raceignore. Initialize raceignore to zero when initially
setting racectx.

A goroutine can end with a non-zero raceignore if it exits
after calling runtime.RaceDisable without a matching
runtime.RaceEnable. If that goroutine's g is later reused
the race detector is in a weird state: the underlying
g.racectx is active, yet g.raceignore is non-zero, and
raceacquire/racerelease which check g.raceignore become
no-ops. This causes the race detector to report races when
there are none.

Fixes #60934

Change-Id: Ib8e412f11badbaf69a480f03740da70891f4093f
Reviewed-on: https://go-review.googlesource.com/c/go/+/505055
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
2023-06-23 16:46:25 +00:00
..
archive
arena
bufio
builtin cmp, builtin: document NaN behavior 2023-06-11 00:41:42 +00:00
bytes
cmd cmd/compile: scanning closures body when visiting wrapper function 2023-06-23 14:29:16 +00:00
cmp cmp, builtin: document NaN behavior 2023-06-11 00:41:42 +00:00
compress compress/bzip2: fix typo 2023-06-16 18:24:46 +00:00
container
context context: fix doc tipo (s/timout/timeout) 2023-06-11 00:33:08 +00:00
crypto crypto: document non-determinism of GenerateKey 2023-06-23 16:12:46 +00:00
database/sql database/sql: fix flake in TestContextCancelDuringRawBytesScan 2023-06-13 19:41:21 +00:00
debug
embed
encoding encoding/binary: on invalid type return -1 from Size 2023-06-20 18:28:44 +00:00
errors
expvar
flag
fmt
go go/types, types2: avoid spurious "declared and not used" error 2023-06-21 18:32:13 +00:00
hash all: fix spelling errors 2023-06-14 00:03:57 +00:00
html
image
index/suffixarray
internal internal/platform,cmd/dist: export the list of supported platforms 2023-06-22 19:44:52 +00:00
io
log log/slog: fix broken link to AnyValue in comment 2023-06-23 12:15:52 +00:00
maps
math math: document that Min/Max differ from min/max 2023-06-15 19:45:12 +00:00
mime all: fix spelling errors 2023-06-14 00:03:57 +00:00
net net/mail: permit more characters in mail headers 2023-06-21 21:39:08 +00:00
os os/exec: document a method to check if a process is alive 2023-06-17 19:02:45 +00:00
path path/filepath: avoid assuming that GOROOT/test is present 2023-06-16 19:37:46 +00:00
plugin
reflect reflect: fix ArenaNew to match documentation 2023-06-16 17:08:43 +00:00
regexp
runtime runtime: set raceignore to zero when starting a new goroutine 2023-06-23 16:46:25 +00:00
slices slices: add sort benchmark for sorted strings 2023-06-15 16:58:05 +00:00
sort sort: comments directing new code to use the slices package when applicable 2023-06-13 18:07:00 +00:00
strconv
strings
sync
syscall syscall: Fix Getwd on Windows to correctly handle long paths. 2023-06-14 13:30:22 +00:00
testdata
testing testing/fstest: fix the Glob test when dir entries are out of order 2023-06-16 18:21:40 +00:00
text text/template: set variables correctly in range assignment 2023-06-15 14:28:01 +00:00
time
unicode
unsafe
vendor all: update vendored dependencies 2023-06-13 21:37:23 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2023-06-13 21:37:23 +00:00
go.sum all: update vendored dependencies 2023-06-13 21:37:23 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.