Muir Manders c07e1c6ef6 internal/lsp: improve variadic completion ... Improve candidate ranking when completing the variadic parameter of function calls. Using the example: func foo(strs ...string) {} - When completing foo(<>), we prefer candidates of type []string or string (previously we only preferred []string). - When completing foo("hi", <>), we prefer candidates of type string (previously we preferred []string). - When completing foo(<>), we use a snippet to add on the "..." automatically to candidates of type []string. I also fixed completion tests to work properly when you have multiple notes referring to the same position. For example: foo() //@rank(")", a, b),rank(")", a, c) Previously the second "rank" was silently overwriting the first because they both refer to the same ")". Fixes golang/go#34334. Change-Id: I4f64be44a4ccbb533fb7682738c759cbca3a93cd Reviewed-on: https://go-review.googlesource.com/c/tools/+/205117 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-11-07 18:57:33 +00:00
..
completion.go	internal/lsp/source: propose exports for unimported packages	2019-11-04 21:31:03 +00:00
diagnostics.go	internal/lsp: use the AST to get correct ranges	2019-10-22 16:21:03 +00:00
links.go	tools/gopls: add command line support for links	2019-11-01 17:18:15 +00:00
tests.go	internal/lsp: improve variadic completion	2019-11-07 18:57:33 +00:00