1
0
mirror of https://github.com/golang/go synced 2024-11-18 19:54:44 -07:00
go/internal/lsp/cache
Rohan Challa 46bd65c853 internal/lsp/cache: add concurrency error check for go cmds
This change attempts to fix a concurrency error that would cause
textDocument/CodeLens, textDocument/Formatting, textDocument/DocumentLink,
and textDocument/Hover from failing on go.mod files.

The issue was that the go command would return a potential concurrency
error since the ModHandle and the ModTidyHandle are both using the
temporary go.mod file.

Updates golang/go#37824

Change-Id: I6cd63c1f75817c7308e033aec473966536a2a3bd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/224917
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-04-08 03:22:09 +00:00
..
analysis.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
cache.go internal/lsp: move the debug.Instance onto the Context 2020-03-03 22:54:53 +00:00
check.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
debug.go internal/lsp/lsprpc: add a handshake between forwarder and remote 2020-02-24 22:51:04 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
external.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
load.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
mod.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp/source: remove unused parameters from functions 2020-03-27 18:57:18 +00:00
pkg.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
session.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
snapshot.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00