mirror of
https://github.com/golang/go
synced 2024-11-24 04:00:13 -07:00
abefcac10a
For most nodes (e.g., OPTRLIT, OMAKESLICE, OCONVIFACE), escape analysis prints "escapes to heap" or "does not escape" to indicate whether that node's allocation can be heap or stack allocated. These messages are also emitted for OADDR, even though OADDR does not actually allocate anything itself. Moreover, it's redundant because escape analysis already prints "moved to heap" diagnostics when an OADDR node like "&x" causes x to require heap allocation. Because OADDR nodes don't allocate memory, my escape analysis rewrite doesn't naturally emit the "escapes to heap" / "does not escape" diagnostics for them. It's also non-trivial to replicate the exact semantics esc.go uses for OADDR. Since there are so many of these messages, I'm disabling them in this CL by themselves. I modified esc.go to suppress the Warnl calls without any other behavior changes, and then used a shell script to automatically remove any ERROR messages mentioned by run.go in "missing error" or "no match for" lines. Fixes #16300. Updates #23109. Change-Id: I3993e2743c3ff83ccd0893f4e73b366ff8871a57 Reviewed-on: https://go-review.googlesource.com/c/go/+/170319 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com>
174 lines
4.8 KiB
Go
174 lines
4.8 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis for closure arguments.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
func ClosureCallArgs0() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
// BAD: x should not escape to heap here
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs1() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
for {
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
// BAD: x should not escape to heap here
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs2() {
|
|
for {
|
|
// BAD: x should not escape here
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs3() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
sink = p // ERROR "p escapes to heap"
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs4() {
|
|
// BAD: x should not leak here
|
|
x := 0 // ERROR "moved to heap: x"
|
|
_ = func(p *int) *int { // ERROR "leaking param: p to result ~r1" "func literal does not escape"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs5() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
sink = func(p *int) *int { // ERROR "leaking param: p to result ~r1" "func literal does not escape" "\(func literal\)\(&x\) escapes to heap"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs6() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "moved to heap: p" "func literal does not escape"
|
|
sink = &p // ERROR "&p escapes to heap"
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs7() {
|
|
var pp *int
|
|
for {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
pp = p
|
|
}(&x)
|
|
}
|
|
_ = pp
|
|
}
|
|
|
|
func ClosureCallArgs8() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
// BAD: x should not escape to heap here
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs9() {
|
|
// BAD: x should not leak
|
|
x := 0 // ERROR "moved to heap: x"
|
|
for {
|
|
defer func(p *int) { // ERROR "func literal escapes to heap" "p does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs10() {
|
|
for {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "func literal escapes to heap" "p does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs11() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
sink = p // ERROR "p escapes to heap"
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs12() {
|
|
// BAD: x should not leak
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) *int { // ERROR "leaking param: p to result ~r1" "func literal does not escape"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs13() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "moved to heap: p" "func literal does not escape"
|
|
sink = &p // ERROR "&p escapes to heap"
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs14() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
// BAD: &x should not escape here
|
|
p := &x // ERROR "moved to heap: p"
|
|
_ = func(p **int) *int { // ERROR "leaking param: p to result ~r1 level=1" "func literal does not escape"
|
|
return *p
|
|
// BAD: p should not escape here
|
|
}(&p)
|
|
}
|
|
|
|
func ClosureCallArgs15() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
p := &x // ERROR "moved to heap: p"
|
|
sink = func(p **int) *int { // ERROR "leaking param: p to result ~r1 level=1" "func literal does not escape" "\(func literal\)\(&p\) escapes to heap"
|
|
return *p
|
|
// BAD: p should not escape here
|
|
}(&p)
|
|
}
|
|
|
|
func ClosureLeak1(s string) string { // ERROR "ClosureLeak1 s does not escape"
|
|
t := s + "YYYY" // ERROR "escapes to heap"
|
|
return ClosureLeak1a(t) // ERROR "ClosureLeak1 ... argument does not escape"
|
|
}
|
|
|
|
// See #14409 -- returning part of captured var leaks it.
|
|
func ClosureLeak1a(a ...string) string { // ERROR "leaking param: a to result ~r1 level=1"
|
|
return func() string { // ERROR "ClosureLeak1a func literal does not escape"
|
|
return a[0]
|
|
}()
|
|
}
|
|
|
|
func ClosureLeak2(s string) string { // ERROR "ClosureLeak2 s does not escape"
|
|
t := s + "YYYY" // ERROR "escapes to heap"
|
|
c := ClosureLeak2a(t) // ERROR "ClosureLeak2 ... argument does not escape"
|
|
return c
|
|
}
|
|
func ClosureLeak2a(a ...string) string { // ERROR "leaking param: a to result ~r1 level=1"
|
|
return ClosureLeak2b(func() string { // ERROR "ClosureLeak2a func literal does not escape"
|
|
return a[0]
|
|
})
|
|
}
|
|
func ClosureLeak2b(f func() string) string { // ERROR "leaking param: f to result ~r1 level=1"
|
|
return f()
|
|
}
|