mirror of
https://github.com/golang/go
synced 2024-11-24 21:40:09 -07:00
abefcac10a
For most nodes (e.g., OPTRLIT, OMAKESLICE, OCONVIFACE), escape analysis prints "escapes to heap" or "does not escape" to indicate whether that node's allocation can be heap or stack allocated. These messages are also emitted for OADDR, even though OADDR does not actually allocate anything itself. Moreover, it's redundant because escape analysis already prints "moved to heap" diagnostics when an OADDR node like "&x" causes x to require heap allocation. Because OADDR nodes don't allocate memory, my escape analysis rewrite doesn't naturally emit the "escapes to heap" / "does not escape" diagnostics for them. It's also non-trivial to replicate the exact semantics esc.go uses for OADDR. Since there are so many of these messages, I'm disabling them in this CL by themselves. I modified esc.go to suppress the Warnl calls without any other behavior changes, and then used a shell script to automatically remove any ERROR messages mentioned by run.go in "missing error" or "no match for" lines. Fixes #16300. Updates #23109. Change-Id: I3993e2743c3ff83ccd0893f4e73b366ff8871a57 Reviewed-on: https://go-review.googlesource.com/c/go/+/170319 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com>
54 lines
1.5 KiB
Go
54 lines
1.5 KiB
Go
// +build !nacl,!386,!wasm,!arm,!gcflags_noopt
|
|
// errorcheck -0 -m
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test, using compiler diagnostic flags, that inlining of functions
|
|
// imported from the sync package is working.
|
|
// Compiles but does not run.
|
|
|
|
// FIXME: This test is disabled on architectures where atomic operations
|
|
// are function calls rather than intrinsics, since this prevents inlining
|
|
// of the sync fast paths. This test should be re-enabled once the problem
|
|
// is solved.
|
|
|
|
package foo
|
|
|
|
import (
|
|
"sync"
|
|
)
|
|
|
|
var mutex *sync.Mutex
|
|
|
|
func small5() { // ERROR "can inline small5"
|
|
// the Unlock fast path should be inlined
|
|
mutex.Unlock() // ERROR "inlining call to sync\.\(\*Mutex\)\.Unlock"
|
|
}
|
|
|
|
func small6() { // ERROR "can inline small6"
|
|
// the Lock fast path should be inlined
|
|
mutex.Lock() // ERROR "inlining call to sync\.\(\*Mutex\)\.Lock"
|
|
}
|
|
|
|
var once *sync.Once
|
|
|
|
func small7() { // ERROR "can inline small7"
|
|
// the Do fast path should be inlined
|
|
once.Do(small5) // ERROR "inlining call to sync\.\(\*Once\)\.Do"
|
|
}
|
|
|
|
var rwmutex *sync.RWMutex
|
|
|
|
func small8() { // ERROR "can inline small8"
|
|
// the RUnlock fast path should be inlined
|
|
rwmutex.RUnlock() // ERROR "inlining call to sync\.\(\*RWMutex\)\.RUnlock"
|
|
}
|
|
|
|
func small9() { // ERROR "can inline small9"
|
|
// the RLock fast path should be inlined
|
|
rwmutex.RLock() // ERROR "inlining call to sync\.\(\*RWMutex\)\.RLock"
|
|
}
|
|
|