mirror of
https://github.com/golang/go
synced 2024-11-24 21:50:11 -07:00
abefcac10a
For most nodes (e.g., OPTRLIT, OMAKESLICE, OCONVIFACE), escape analysis prints "escapes to heap" or "does not escape" to indicate whether that node's allocation can be heap or stack allocated. These messages are also emitted for OADDR, even though OADDR does not actually allocate anything itself. Moreover, it's redundant because escape analysis already prints "moved to heap" diagnostics when an OADDR node like "&x" causes x to require heap allocation. Because OADDR nodes don't allocate memory, my escape analysis rewrite doesn't naturally emit the "escapes to heap" / "does not escape" diagnostics for them. It's also non-trivial to replicate the exact semantics esc.go uses for OADDR. Since there are so many of these messages, I'm disabling them in this CL by themselves. I modified esc.go to suppress the Warnl calls without any other behavior changes, and then used a shell script to automatically remove any ERROR messages mentioned by run.go in "missing error" or "no match for" lines. Fixes #16300. Updates #23109. Change-Id: I3993e2743c3ff83ccd0893f4e73b366ff8871a57 Reviewed-on: https://go-review.googlesource.com/c/go/+/170319 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com>
161 lines
3.5 KiB
Go
161 lines
3.5 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis when assigning to indirections.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
type ConstPtr struct {
|
|
p *int
|
|
c ConstPtr2
|
|
x **ConstPtr
|
|
}
|
|
|
|
type ConstPtr2 struct {
|
|
p *int
|
|
i int
|
|
}
|
|
|
|
func constptr0() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
// BAD: i should not escape here
|
|
x.p = &i
|
|
_ = x
|
|
}
|
|
|
|
func constptr01() *ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap"
|
|
x.p = &i
|
|
return x
|
|
}
|
|
|
|
func constptr02() ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
x.p = &i
|
|
return *x
|
|
}
|
|
|
|
func constptr03() **ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap" "moved to heap: x"
|
|
x.p = &i
|
|
return &x
|
|
}
|
|
|
|
func constptr1() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap"
|
|
x.p = &i
|
|
sink = x // ERROR "x escapes to heap"
|
|
}
|
|
|
|
func constptr2() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
x.p = &i
|
|
sink = *x // ERROR "\*x escapes to heap"
|
|
}
|
|
|
|
func constptr4() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
*p = *&ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
return p
|
|
}
|
|
|
|
func constptr5() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
*p = *p1
|
|
return p
|
|
}
|
|
|
|
// BAD: p should not escape here
|
|
func constptr6(p *ConstPtr) { // ERROR "leaking param content: p"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
*p1 = *p
|
|
_ = p1
|
|
}
|
|
|
|
func constptr7() **ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap" "moved to heap: p"
|
|
var tmp ConstPtr2
|
|
p1 := &tmp
|
|
p.c = *p1
|
|
return &p
|
|
}
|
|
|
|
func constptr8() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
var tmp ConstPtr2
|
|
p.c = *&tmp
|
|
return p
|
|
}
|
|
|
|
func constptr9() ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) does not escape"
|
|
var p1 ConstPtr2
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p1.p = &i
|
|
p.c = p1
|
|
return *p
|
|
}
|
|
|
|
func constptr10() ConstPtr {
|
|
x := &ConstPtr{} // ERROR "moved to heap: x" "&ConstPtr literal escapes to heap"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
var p *ConstPtr
|
|
p = &ConstPtr{p: &i, x: &x} // ERROR "&ConstPtr literal does not escape"
|
|
var pp **ConstPtr
|
|
pp = &p
|
|
return **pp
|
|
}
|
|
|
|
func constptr11() *ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
p1.p = &i
|
|
*p = *p1
|
|
return p
|
|
}
|
|
|
|
func foo(p **int) { // ERROR "foo p does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
y := p
|
|
*y = &i
|
|
}
|
|
|
|
func foo1(p *int) { // ERROR "p does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
y := &p
|
|
*y = &i
|
|
}
|
|
|
|
func foo2() {
|
|
type Z struct {
|
|
f **int
|
|
}
|
|
x := new(int) // ERROR "moved to heap: x" "new\(int\) escapes to heap"
|
|
sink = &x // ERROR "&x escapes to heap"
|
|
var z Z
|
|
z.f = &x
|
|
p := z.f
|
|
i := 0 // ERROR "moved to heap: i"
|
|
*p = &i
|
|
}
|
|
|
|
var global *byte
|
|
|
|
func f() {
|
|
var x byte // ERROR "moved to heap: x"
|
|
global = &*&x
|
|
}
|