1
0
mirror of https://github.com/golang/go synced 2024-11-18 21:05:02 -07:00
go/internal/lsp/source
Rob Findley 8ddc06776e internal/lsp/source: don't link to packages matching GOPRIVATE in hover
Currently, our hover text by default links point to public documentation
sites (e.g. pkg.go.dev). This doesn't make sense for private repos, so
hide the hovertext link when the import path matches GOPRIVATE.

Implementing this was a little messy. To be optimal I had to thread
the value of goprivate through cache.view, and to be correct I had to
duplicate some code from cmd/go internal.

Regtest will follow after https://golang.org/cl/232983 is submitted.

Updates golang/go#36998

Change-Id: I1e556471bf919fea30132d9642426a08fdb7f434
Reviewed-on: https://go-review.googlesource.com/c/tools/+/233524
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-05-15 19:36:02 +00:00
..
code_lens.go internal/lsp: add run test code lens 2020-05-12 13:19:52 +00:00
comment_test.go
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_format.go internal/lsp: handle different package names in signature help 2020-04-27 20:59:12 +00:00
completion_keywords.go internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_statements.go internal/lsp/source: offer completion "if err != nil { return err }" 2020-03-10 21:06:53 +00:00
completion.go internal/lsp: return early in completion where possible 2020-05-07 20:50:54 +00:00
deep_completion.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
diagnostics.go internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
folding_range.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
highlight.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
hover.go internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00
identifier.go internal/lsp/source: handle nil pointer in package name hover 2020-05-11 19:44:01 +00:00
implementation.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
options.go internal/lsp: add run test code lens 2020-05-12 13:19:52 +00:00
references.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
rename_check.go internal/lsp/source: remove unused parameters from functions 2020-03-27 18:57:18 +00:00
rename.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
signature_help.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
source_test.go internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00
symbols.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
types_format.go internal/lsp: return in the default case in cloneExpr 2020-05-09 03:07:07 +00:00
util.go internal/lsp: refactor code for formatting signatures 2020-04-22 20:52:58 +00:00
view.go internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00