mirror of
https://github.com/golang/go
synced 2024-09-28 23:24:33 -06:00
4360fd8d6f
This matches longstanding compiler behavior. Also, for unused packages, report: `"pkg" imported and not used` `"pkg" imported as X and not used` This matches the other `X declared and not used` errors. For #55326. Change-Id: Ie71cf662fb5f4648449c64fc51bede298a1bdcbf Reviewed-on: https://go-review.googlesource.com/c/go/+/432557 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Run-TryBot: Robert Griesemer <gri@google.com>
57 lines
1.1 KiB
Go
57 lines
1.1 KiB
Go
// +build !js,gc
|
|
// run
|
|
|
|
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// As of "Mon 6 Nov 2017", run.go doesn't yet have proper
|
|
// column matching so instead match the output manually
|
|
// by exec-ing
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"log"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
)
|
|
|
|
func main() {
|
|
f, err := ioutil.TempFile("", "issue21317.go")
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
fmt.Fprintf(f, `
|
|
package main
|
|
|
|
import "fmt"
|
|
|
|
func main() {
|
|
n, err := fmt.Println(1)
|
|
}
|
|
`)
|
|
f.Close()
|
|
defer os.RemoveAll(f.Name())
|
|
|
|
// compile and test output
|
|
cmd := exec.Command("go", "tool", "compile", "-p=main", f.Name())
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
log.Fatalf("expected cmd/compile to fail")
|
|
}
|
|
wantErrs := []string{
|
|
"7:9: n declared and not used",
|
|
"7:12: err declared and not used",
|
|
}
|
|
outStr := string(out)
|
|
for _, want := range wantErrs {
|
|
if !strings.Contains(outStr, want) {
|
|
log.Fatalf("failed to match %q\noutput: %q", want, outStr)
|
|
}
|
|
}
|
|
}
|