Heschi Kreinick 412b8bda49 internal/lsp/cache: ref-count snapshots ... To manually collect cache entries, we need to know when a snapshot is idle. Add a reference count in the form of a WaitGroup and keep track of its uses. The pattern is that any time a snapshot is returned, it comes with a release function that decrements the ref count. Almost all uses of a snapshot originate in a user-facing request, handled in beginFileRequest. There it's mostly an exercise in passing Snapshots around instead of Views. In the other places I took the path of least resistance. For file modifications I tried to minimize the amount of code that needed to deal with snapshots. For diagnostics I just acquired the snapshot at the diagnostics call. Change-Id: Id48a2df3acdd97f27d905e2c2be23072f28f196b Reviewed-on: https://go-review.googlesource.com/c/tools/+/241837 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-08-03 22:08:54 +00:00
..
testdata/unchanged	internal/lsp/tests: fix reset of golden files	2020-02-19 14:42:13 +00:00
code_lens.go	internal/lsp: remove Mod handles	2020-07-29 19:44:36 +00:00
diagnostics.go	internal/lsp: remove Mod handles	2020-07-29 19:44:36 +00:00
format.go	internal/lsp: remove Mod handles	2020-07-29 19:44:36 +00:00
hover.go	internal/lsp: remove Mod handles	2020-07-29 19:44:36 +00:00
mod_test.go	internal/lsp/cache: ref-count snapshots	2020-08-03 22:08:54 +00:00