mirror of
https://github.com/golang/go
synced 2024-11-24 22:37:56 -07:00
4534fdb144
A runtime.Goexit during a panic-invoked deferred call left the panic stack intact even though all the stack frames are gone when the goroutine is torn down. The next goroutine to reuse that struct will have a bogus panic stack and can cause the traceback routines to walk into garbage. Most likely to happen during tests, because t.Fatal might be called during a deferred func and uses runtime.Goexit. This "not enough cleared in Goexit" failure mode has happened to us multiple times now. Clear all the pointers that don't make sense to keep, not just gp->panic. Fixes #8158. LGTM=iant, dvyukov R=iant, dvyukov CC=golang-codereviews https://golang.org/cl/102220043
42 lines
768 B
Go
42 lines
768 B
Go
// run
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"runtime"
|
|
"time"
|
|
)
|
|
|
|
func main() {
|
|
c := make(chan bool, 1)
|
|
go f1(c)
|
|
<-c
|
|
time.Sleep(10 * time.Millisecond)
|
|
go f2(c)
|
|
<-c
|
|
}
|
|
|
|
func f1(done chan bool) {
|
|
defer func() {
|
|
recover()
|
|
done <- true
|
|
runtime.Goexit() // left stack-allocated Panic struct on gp->panic stack
|
|
}()
|
|
panic("p")
|
|
}
|
|
|
|
func f2(done chan bool) {
|
|
defer func() {
|
|
recover()
|
|
done <- true
|
|
runtime.Goexit()
|
|
}()
|
|
time.Sleep(10 * time.Millisecond) // overwrote Panic struct with Timer struct
|
|
runtime.GC() // walked gp->panic list, found mangled Panic struct, crashed
|
|
panic("p")
|
|
}
|