402f177efc
I found a performance regression between the runtime.Hash benchmarks when comparing Go 1.16 to latest on ppc64le. This was due to the addition of Mul64 to runtime/internal/math with the comments that this should be treated as an intrinsic on platforms where available. However this is was not being intrinsified on ppc64le because the code in ssagen/ssa.go didn't correctly specify ppc64le. It had the argument for ArchPPC64 but should have also included ArchPPC64LE. Treating Mul64 as an intrinsic shows this improvement, and these results are better than Go 1.16: Hash5 27.0ns ± 0% 14.0ns ± 0% -48.1 Hash16 26.6ns ± 0% 14.0ns ± 0% -47.3 Hash64 50.7ns ± 0% 17.9ns ± 0% -64.6 Hash1024 500ns ± 0% 99ns ± 0% -80.1 Hash65536 30.6µs ± 0% 4.0µs ± 0% -86 Many of the Map related benchmarks in the runtime package also showed improvement once Mul64 is intrinsified. Change-Id: I3b5ce637b1620348d81a30cfc359c97ab63aae0f Reviewed-on: https://go-review.googlesource.com/c/go/+/317303 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Paul Murphy <murp@ibm.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Go Bot <gobot@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.