Rebecca Stambler 4025ed8474 internal/lsp: move fillstruct suggested fixes out of analysis ... This change moves the suggested fixes logic for fillstruct out of the analysis and into internal/lsp/source. This logic is then used as part of a new fillstruct command. This command is returned along with the code action results, to be executed only when the user accepts the code action. This led to a number of changes to testing. The suggested fix tests in internal/lsp doesn't support executing commands, so we skip them. The suggested fix tests in internal/lsp/source are changed to call fillstruct directly. A new regtest is added to check the command execution, which led to a few regtest changes. Also, remove the `go mod tidy` code action, as it's made redundant by the existence of the suggested fixes coming from internal/lsp/mod. Change-Id: I35ca0aff1ace8f0097fe7cb57232997facb516a4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241983 Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-07-20 20:42:44 +00:00
..
codelens_test.go	internal/lsp: don't use -modfile for go mod commands	2020-06-22 20:30:43 +00:00
definition_test.go	internal/lsp/regtest: put testing.T back in the test func signature	2020-04-14 18:42:46 +00:00
diagnostics_test.go	internal/lsp: don't keep track of closed overlays	2020-07-16 17:49:00 +00:00
doc.go	internal/lsp/regtest: add expository package documentation	2020-04-28 21:10:48 +00:00
env_test.go	internal/lsp: instrument work done reporting to use in regtests	2020-04-28 20:46:32 +00:00
env.go	internal/lsp/regtest: add regression tests for on-disk file changes	2020-07-01 22:06:37 +00:00
fix_test.go	internal/lsp: move fillstruct suggested fixes out of analysis	2020-07-20 20:42:44 +00:00
formatting_test.go	gopls, internal/lsp: support an extra formatting hook for gofumpt	2020-07-13 21:42:47 +00:00
generate_test.go	internal/lsp/regtest: add support for testing generate commands	2020-05-04 19:25:30 +00:00
imports_test.go	internal/lsp/regtest: remove stray short timeout	2020-07-08 18:38:56 +00:00
link_test.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
modfile_test.go	internal/lsp: refactor go.mod diagnostics to simplify the API	2020-07-16 22:50:03 +00:00
reg_test.go	internal/lsp/regtest: simpler way to invert options	2020-07-16 18:20:50 +00:00
runner.go	internal/lsp/lsprpc: improvements to daemon logging	2020-07-16 19:33:22 +00:00
shared_test.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
symbol_helper_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
symbol_test.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00
unix_test.go	internal/lsp/regtest: add a t.Skip for golang/go#36824 regtest	2020-05-21 15:57:04 +00:00
vendor_test.go	internal/lsp: support go mod vendor as a command	2020-06-04 18:33:45 +00:00
watch_test.go	internal/lsp/regtest: await IWL before running tests	2020-07-08 00:37:08 +00:00
wrappers.go	internal/lsp: move fillstruct suggested fixes out of analysis	2020-07-20 20:42:44 +00:00