mirror of
https://github.com/golang/go
synced 2024-11-19 02:04:42 -07:00
d2cdbefbfc
See json.go for interface specification. Example usage: % oracle -format=json -mode=callgraph code.google.com/p/go.tools/cmd/oracle + Tests, based on (small) golden files. Overview: Each <query>Result structure has been "lowered" so that all but the most trivial logic in each display() function has been moved to the main query. Each one now has a toJSON method that populates a json.Result struct. Though the <query>Result structs are similar to the correponding JSON protocol, they're not close enough to be used directly; for example, the former contain richer semantic entities (token.Pos, ast.Expr, ssa.Value, pointer.Pointer, etc) whereas JSON contains only their printed forms using Go basic types. The choices of what levels of abstractions the two sets of structs should have is somewhat arbitrary. We may want richer information in the JSON output in future. Details: - oracle.Main has been split into oracle.Query() and the printing of the oracle.Result. - the display() method no longer needs an *oracle param, only a print function. - callees: sort the result for determinism. - callees: compute the union across all contexts. - callers: sort the results for determinism. - describe(package): fixed a bug in the predicate for method accessibility: an unexported method defined in pkg A may belong to a type defined in package B (via embedding/promotion) and may thus be accessible to A. New accessibleMethods() utility fixes this. - describe(type): filter methods by accessibility. - added tests of 'callgraph'. - pointer: eliminated the 'caller CallGraphNode' parameter from pointer.Context.Call callback since it was redundant w.r.t site.Caller(). - added warning if CGO_ENABLED is unset. R=crawshaw CC=golang-dev https://golang.org/cl/13270045
188 lines
4.6 KiB
Go
188 lines
4.6 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package oracle
|
|
|
|
import (
|
|
"go/ast"
|
|
"go/token"
|
|
"sort"
|
|
|
|
"code.google.com/p/go.tools/go/types"
|
|
"code.google.com/p/go.tools/oracle/json"
|
|
)
|
|
|
|
// freevars displays the lexical (not package-level) free variables of
|
|
// the selection.
|
|
//
|
|
// It treats A.B.C as a separate variable from A to reveal the parts
|
|
// of an aggregate type that are actually needed.
|
|
// This aids refactoring.
|
|
//
|
|
// TODO(adonovan): optionally display the free references to
|
|
// file/package scope objects, and to objects from other packages.
|
|
// Depending on where the resulting function abstraction will go,
|
|
// these might be interesting. Perhaps group the results into three
|
|
// bands.
|
|
//
|
|
func freevars(o *oracle) (queryResult, error) {
|
|
file := o.queryPath[len(o.queryPath)-1] // the enclosing file
|
|
|
|
// The id and sel functions return non-nil if they denote an
|
|
// object o or selection o.x.y that is referenced by the
|
|
// selection but defined neither within the selection nor at
|
|
// file scope, i.e. it is in the lexical environment.
|
|
var id func(n *ast.Ident) types.Object
|
|
var sel func(n *ast.SelectorExpr) types.Object
|
|
|
|
sel = func(n *ast.SelectorExpr) types.Object {
|
|
switch x := unparen(n.X).(type) {
|
|
case *ast.SelectorExpr:
|
|
return sel(x)
|
|
case *ast.Ident:
|
|
return id(x)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
id = func(n *ast.Ident) types.Object {
|
|
obj := o.queryPkgInfo.ObjectOf(n)
|
|
if obj == nil {
|
|
return nil // TODO(adonovan): fix: this fails for *types.Label.
|
|
panic(o.errorf(n, "no types.Object for ast.Ident"))
|
|
}
|
|
if _, ok := obj.(*types.Package); ok {
|
|
return nil // imported package
|
|
}
|
|
if n.Pos() == obj.Pos() {
|
|
return nil // this ident is the definition, not a reference
|
|
}
|
|
if !(file.Pos() <= obj.Pos() && obj.Pos() <= file.End()) {
|
|
return nil // not defined in this file
|
|
}
|
|
if obj.Parent() == nil {
|
|
return nil // e.g. interface method TODO(adonovan): what else?
|
|
}
|
|
if obj.Parent() == o.queryPkgInfo.Scopes[file] {
|
|
return nil // defined at file scope
|
|
}
|
|
if o.startPos <= obj.Pos() && obj.Pos() <= o.endPos {
|
|
return nil // defined within selection => not free
|
|
}
|
|
return obj
|
|
}
|
|
|
|
// Maps each reference that is free in the selection
|
|
// to the object it refers to.
|
|
// The map de-duplicates repeated references.
|
|
refsMap := make(map[string]freevarsRef)
|
|
|
|
// Visit all the identifiers in the selected ASTs.
|
|
ast.Inspect(o.queryPath[0], func(n ast.Node) bool {
|
|
if n == nil {
|
|
return true // popping DFS stack
|
|
}
|
|
|
|
// Is this node contained within the selection?
|
|
// (freevars permits inexact selections,
|
|
// like two stmts in a block.)
|
|
if o.startPos <= n.Pos() && n.End() <= o.endPos {
|
|
var obj types.Object
|
|
var prune bool
|
|
switch n := n.(type) {
|
|
case *ast.Ident:
|
|
obj = id(n)
|
|
|
|
case *ast.SelectorExpr:
|
|
obj = sel(n)
|
|
prune = true
|
|
}
|
|
|
|
if obj != nil {
|
|
var kind string
|
|
switch obj.(type) {
|
|
case *types.Var:
|
|
kind = "var"
|
|
case *types.Func:
|
|
kind = "func"
|
|
case *types.TypeName:
|
|
kind = "type"
|
|
case *types.Const:
|
|
kind = "const"
|
|
case *types.Label:
|
|
kind = "label"
|
|
default:
|
|
panic(obj)
|
|
}
|
|
|
|
typ := o.queryPkgInfo.TypeOf(n.(ast.Expr))
|
|
ref := freevarsRef{kind, o.printNode(n), typ, obj}
|
|
refsMap[ref.ref] = ref
|
|
|
|
if prune {
|
|
return false // don't descend
|
|
}
|
|
}
|
|
}
|
|
|
|
return true // descend
|
|
})
|
|
|
|
refs := make([]freevarsRef, 0, len(refsMap))
|
|
for _, ref := range refsMap {
|
|
refs = append(refs, ref)
|
|
}
|
|
sort.Sort(byRef(refs))
|
|
|
|
return &freevarsResult{
|
|
fset: o.prog.Fset,
|
|
refs: refs,
|
|
}, nil
|
|
}
|
|
|
|
type freevarsResult struct {
|
|
fset *token.FileSet
|
|
refs []freevarsRef
|
|
}
|
|
|
|
type freevarsRef struct {
|
|
kind string
|
|
ref string
|
|
typ types.Type
|
|
obj types.Object
|
|
}
|
|
|
|
func (r *freevarsResult) display(printf printfFunc) {
|
|
if len(r.refs) == 0 {
|
|
printf(false, "No free identifers.")
|
|
} else {
|
|
printf(false, "Free identifers:")
|
|
for _, ref := range r.refs {
|
|
printf(ref.obj, "%s %s %s", ref.kind, ref.ref, ref.typ)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (r *freevarsResult) toJSON(res *json.Result, fset *token.FileSet) {
|
|
var refs []*json.FreeVar
|
|
for _, ref := range r.refs {
|
|
refs = append(refs,
|
|
&json.FreeVar{
|
|
Pos: fset.Position(ref.obj.Pos()).String(),
|
|
Kind: ref.kind,
|
|
Ref: ref.ref,
|
|
Type: ref.typ.String(),
|
|
})
|
|
}
|
|
res.Freevars = refs
|
|
}
|
|
|
|
// -------- utils --------
|
|
|
|
type byRef []freevarsRef
|
|
|
|
func (p byRef) Len() int { return len(p) }
|
|
func (p byRef) Less(i, j int) bool { return p[i].ref < p[j].ref }
|
|
func (p byRef) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
|