1
0
mirror of https://github.com/golang/go synced 2024-11-19 13:04:45 -07:00
The Go programming language
Go to file
Dmitri Shuralyov 3e801416ce cmd/go: fix build -o panic when import path pattern matches 0 pkgs
Fixes #8165.

After this change, the panic is replaced by a message:

        $ go build -o out ...doesntexist
        warning: "...doesntexist" matched no packages
        no packages to build

The motivation to return 1 exit error code is to allow -o flag
to be used to guarantee that the output binary is written to
when exit status is 0. If someone uses an import path pattern
to specify a single package and suddenly that matches no packages,
it's better to return exit code 1 instead of silently doing nothing.
This is consistent with the case when -o flag is given and multiple
packages are matched.
It's also somewhat consistent with the current behavior with the
panic, except that gave return code 2. But it's similar in
that it's also non-zero (indicating failure).
I've changed the language to be similar to output of go test
when an import path pattern matches no packages (it also has a return status of
1):

        $ go test ...doesntexist
        warning: "...doesntexist" matched no packages
        no packages to test

LGTM=adg
R=golang-codereviews, josharian, gobot, adg
CC=golang-codereviews
https://golang.org/cl/107140043
2014-07-09 13:17:27 +10:00
api syscall: regenerate z-files for darwin 2014-06-24 09:20:42 +09:00
doc doc/contribute.html: capitalize the first letter 2014-07-07 16:31:20 +10:00
include build: annotations and modifications for c2go 2014-07-02 15:41:29 -04:00
lib codereview: update name of the a+c tool 2014-07-01 09:25:34 -07:00
misc misc/nacl, syscall: lazily initialize fs on nacl. 2014-07-01 18:24:43 -04:00
src cmd/go: fix build -o panic when import path pattern matches 0 pkgs 2014-07-09 13:17:27 +10:00
test test: add test for gccgo comment lexing failure 2014-07-08 14:09:35 -07:00
.hgignore lib9: enable on Plan 9 2014-02-13 20:06:41 +01:00
.hgtags tag go1.3 2014-06-19 11:21:35 +10:00
AUTHORS A+C: Timo Truyts (individual CLA) 2014-07-02 06:45:57 -07:00
CONTRIBUTORS A+C: Timo Truyts (individual CLA) 2014-07-02 06:45:57 -07:00
favicon.ico
LICENSE
PATENTS
README README: Fix installation instructions 2013-11-20 13:47:37 -08:00
robots.txt

This is the source code repository for the Go programming language.  

For documentation about how to install and use Go,
visit http://golang.org/ or load doc/install-source.html
in your web browser.

After installing Go, you can view a nicely formatted
doc/install-source.html by running godoc --http=:6060
and then visiting http://localhost:6060/doc/install/source.

Unless otherwise noted, the Go source files are distributed
under the BSD-style license found in the LICENSE file.

--

Binary Distribution Notes

If you have just untarred a binary Go distribution, you need to set
the environment variable $GOROOT to the full path of the go
directory (the one containing this README).  You can omit the
variable if you unpack it into /usr/local/go, or if you rebuild
from sources by running all.bash (see doc/install.html).
You should also add the Go binary directory $GOROOT/bin
to your shell's path.

For example, if you extracted the tar file into $HOME/go, you might
put the following in your .profile:

    export GOROOT=$HOME/go
    export PATH=$PATH:$GOROOT/bin

See doc/install.html for more details.