1
0
mirror of https://github.com/golang/go synced 2024-11-18 17:44:47 -07:00
go/go
Paul Jolly cfa8b22178 go/packages/packagestest: do not walk packages and their test variants
Currently, where a package has a test variant, we end up walking the
non-_test.go files twice: once when walking the package itself, the
second time when walking the test variant. In the gopls tests, this
means we end up double-counting the number of symbols (via the @symbol
annotation) in a package.

Extend the existing expect_test.go to demonstrate the problem is fixed
(a test which fails when the fix is not in place)

Change-Id: Ifd68b3d86e24f19d3f8efc3af71494b7d28b0acb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228761
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-04-21 04:27:24 +00:00
..
analysis go/analysis/analysistest: print unified diff for test failures 2020-04-15 00:09:39 +00:00
ast go/ast/inspector: impose maximum capacity 2020-04-10 18:16:43 +00:00
buildutil all: fix more typos 2019-09-11 15:13:14 +00:00
callgraph all: add a space before +build in build tag comments 2019-09-08 12:23:18 +00:00
cfg all: fix some staticcheck errors 2020-01-29 04:53:41 +00:00
expect go/packages/packagestest: do not overwrite existing go.mod file 2020-02-06 15:23:23 +00:00
gccgoexportdata go/gccgoexportdata: correctly handle archive files containing string tables 2016-11-09 21:28:38 +00:00
gcexportdata go/gcexportdata: use IExportData when writing gcexportdata 2019-10-04 02:16:33 +00:00
internal internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
loader go/loader: remove check on ioutil.TestTempFile in TestStdlib 2020-04-13 16:19:37 +00:00
packages go/packages/packagestest: do not walk packages and their test variants 2020-04-21 04:27:24 +00:00
pointer all: fix some staticcheck errors 2020-01-29 04:53:41 +00:00
ssa go/ssa/interp: remove unused import 2020-02-25 20:57:19 +00:00
types all: fix some staticcheck errors 2020-01-29 04:53:41 +00:00
vcs go/vcs: ignore "mod" VCS type 2019-05-06 14:53:03 +00:00