Rebecca Stambler 4d14fc9c00 internal/lsp: add type error fixes to existing diagnostics ... This change is the first step in handling golang/go#38136. Instead of creating multiple diagnostic reports for type error analyzers, we add suggested fixes to the existing reports. To match the analyzers for FindAnalysisError, we add an ErrorMatch function to source.Analyzer. This is not an ideal solution, but it was the best one I could come up with without modifying the go/analysis API. analysisinternal could be used for this purpose, but it seemed to complicated to be worth it, and this is fairly simple. I think that go/analysis itself might need to be extended for type error analyzers, but these temporary measures will help us understand the kinds of features we need for type error analyzers. A follow-up CL might be to not add reports for type error analyzers until the end of source.Diagnostic, which would remove the need for the look-up. Fixes golang/go#38136 Change-Id: I25bc6396b09d49facecd918bf5591d2d5bdf1b3a Reviewed-on: https://go-review.googlesource.com/c/tools/+/226777 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>		2020-04-08 01:45:16 +00:00
..
test	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
capabilities_test.go	internal/lsp: remove completion commands	2020-03-21 22:47:14 +00:00
check.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
cmd_test.go	internal/lsp/tests: remove ellipses from test names	2020-03-30 17:55:17 +00:00
cmd.go	internal/jsonrpc2: dont add any handlers by default	2020-04-06 14:44:07 +00:00
definition.go	internal/lsp/cmd: fix definition test to run independently	2020-03-19 21:04:07 +00:00
export_test.go	internal/lsp: refactor query definition test to allow adding a new test	2019-03-18 20:06:54 +00:00
folding_range.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
format.go	internal/lsp: address staticcheck warnings	2019-10-04 02:16:23 +00:00
highlight.go	internal/lsp: add control flow highlighting for functions	2019-12-02 19:01:20 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
imports.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
info.go	internal/lsp: print view-specific environment	2020-03-24 20:15:47 +00:00
inspect.go	internal/lsp/cmd: add an inspect verb	2020-03-12 17:21:45 +00:00
links.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
query.go	internal/lsp: improve link in documentation on hover	2019-12-12 22:39:21 +00:00
references.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
serve_test.go	internal/lsp/lsprpc: automatically resolve and start the remote gopls	2020-02-24 22:51:55 +00:00
serve.go	internal/lsp: rewrite the stats using the newer telemetry features	2020-03-31 00:50:33 +00:00
signature.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
suggested_fix.go	internal/lsp/cmd: improve flexibility of suggested fixes	2020-03-06 14:31:35 +00:00
symbols.go	internal/lsp: support when hierarchicalDocumentSymbolSupport is false	2020-03-06 18:17:37 +00:00
workspace_symbol.go	tools/gopls: add cmd support for workspace_symbol	2020-03-26 19:59:04 +00:00