mirror of
https://github.com/golang/go
synced 2024-11-18 12:54:44 -07:00
a22c11b995
Originally traceback was only used for printing the stack when an unexpected signal came in. In that case, the initial PC is taken from the signal and should be used unaltered. For the callers, the PC is the return address, which might be on the line after the call; we subtract 1 to get to the CALL instruction. Traceback is now used for a variety of things, and for almost all of those the initial PC is a return address, whether from getcallerpc, or gp->sched.pc, or gp->syscallpc. In those cases, we need to subtract 1 from this initial PC, but the traceback code had a hard rule "never subtract 1 from the initial PC", left over from the signal handling days. Change gentraceback to take a flag that specifies whether we are tracing a trap. Change traceback to default to "starting with a return PC", which is the overwhelmingly common case. Add tracebacktrap, like traceback but starting with a trap PC. Use tracebacktrap in signal handlers. Fixes #7690. LGTM=iant, r R=r, iant CC=golang-codereviews https://golang.org/cl/167810044
50 lines
1.2 KiB
Go
50 lines
1.2 KiB
Go
// run
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// issue 7690 - Stack and other routines did not back up initial PC
|
|
// into CALL instruction, instead reporting line number of next instruction,
|
|
// which might be on a different line.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"regexp"
|
|
"runtime"
|
|
"strconv"
|
|
)
|
|
|
|
func main() {
|
|
buf1 := make([]byte, 1000)
|
|
buf2 := make([]byte, 1000)
|
|
|
|
runtime.Stack(buf1, false) // CALL is last instruction on this line
|
|
n := runtime.Stack(buf2, false) // CALL is followed by load of result from stack
|
|
|
|
buf1 = buf1[:bytes.IndexByte(buf1, 0)]
|
|
buf2 = buf2[:n]
|
|
|
|
re := regexp.MustCompile(`(?m)^main\.main\(\)\n.*/issue7690.go:([0-9]+)`)
|
|
m1 := re.FindStringSubmatch(string(buf1))
|
|
if m1 == nil {
|
|
println("BUG: cannot find main.main in first trace")
|
|
return
|
|
}
|
|
m2 := re.FindStringSubmatch(string(buf2))
|
|
if m2 == nil {
|
|
println("BUG: cannot find main.main in second trace")
|
|
return
|
|
}
|
|
|
|
n1, _ := strconv.Atoi(m1[1])
|
|
n2, _ := strconv.Atoi(m2[1])
|
|
if n1+1 != n2 {
|
|
println("BUG: expect runtime.Stack on back to back lines, have", n1, n2)
|
|
println(string(buf1))
|
|
println(string(buf2))
|
|
}
|
|
}
|