mirror of
https://github.com/golang/go
synced 2024-11-18 10:34:51 -07:00
606019cb4b
This information is redundant with the position information already
provided. Also, no other -m diagnostics print out function name.
While here, report parameter leak diagnostics against the parameter
declaration position rather than the function, and use Warnl for
"moved to heap" messages.
Test cases updated programmatically by removing the first word from
every "no match for" error emitted by run.go:
go run run.go |& \
sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \
while IFS='!' read -r fn line before after; do
before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g')
after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g')
fn=$(find . -name "${fn}" | head -1)
sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}"
done
Passes toolstash-check.
Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/195040
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
175 lines
2.9 KiB
Go
175 lines
2.9 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis with respect to field assignments.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
type X struct {
|
|
p1 *int
|
|
p2 *int
|
|
a [2]*int
|
|
}
|
|
|
|
type Y struct {
|
|
x X
|
|
}
|
|
|
|
func field0() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
x.p1 = &i
|
|
sink = x.p1
|
|
}
|
|
|
|
func field1() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
// BAD: &i should not escape
|
|
x.p1 = &i
|
|
sink = x.p2
|
|
}
|
|
|
|
func field3() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
x.p1 = &i
|
|
sink = x // ERROR "x escapes to heap"
|
|
}
|
|
|
|
func field4() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var y Y
|
|
y.x.p1 = &i
|
|
x := y.x
|
|
sink = x // ERROR "x escapes to heap"
|
|
}
|
|
|
|
func field5() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
// BAD: &i should not escape here
|
|
x.a[0] = &i
|
|
sink = x.a[1]
|
|
}
|
|
|
|
// BAD: we are not leaking param x, only x.p2
|
|
func field6(x *X) { // ERROR "leaking param content: x$"
|
|
sink = x.p2
|
|
}
|
|
|
|
func field6a() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
// BAD: &i should not escape
|
|
x.p1 = &i
|
|
field6(&x)
|
|
}
|
|
|
|
func field7() {
|
|
i := 0
|
|
var y Y
|
|
y.x.p1 = &i
|
|
x := y.x
|
|
var y1 Y
|
|
y1.x = x
|
|
_ = y1.x.p1
|
|
}
|
|
|
|
func field8() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var y Y
|
|
y.x.p1 = &i
|
|
x := y.x
|
|
var y1 Y
|
|
y1.x = x
|
|
sink = y1.x.p1
|
|
}
|
|
|
|
func field9() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var y Y
|
|
y.x.p1 = &i
|
|
x := y.x
|
|
var y1 Y
|
|
y1.x = x
|
|
sink = y1.x // ERROR "y1\.x escapes to heap"
|
|
}
|
|
|
|
func field10() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var y Y
|
|
// BAD: &i should not escape
|
|
y.x.p1 = &i
|
|
x := y.x
|
|
var y1 Y
|
|
y1.x = x
|
|
sink = y1.x.p2
|
|
}
|
|
|
|
func field11() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
x := X{p1: &i}
|
|
sink = x.p1
|
|
}
|
|
|
|
func field12() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
// BAD: &i should not escape
|
|
x := X{p1: &i}
|
|
sink = x.p2
|
|
}
|
|
|
|
func field13() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
x := &X{p1: &i} // ERROR "&X literal does not escape$"
|
|
sink = x.p1
|
|
}
|
|
|
|
func field14() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
// BAD: &i should not escape
|
|
x := &X{p1: &i} // ERROR "&X literal does not escape$"
|
|
sink = x.p2
|
|
}
|
|
|
|
func field15() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
x := &X{p1: &i} // ERROR "&X literal escapes to heap$"
|
|
sink = x
|
|
}
|
|
|
|
func field16() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
// BAD: &i should not escape
|
|
x.p1 = &i
|
|
var iface interface{} = x // ERROR "x does not escape"
|
|
x1 := iface.(X)
|
|
sink = x1.p2
|
|
}
|
|
|
|
func field17() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
x.p1 = &i
|
|
var iface interface{} = x // ERROR "x does not escape"
|
|
x1 := iface.(X)
|
|
sink = x1.p1
|
|
}
|
|
|
|
func field18() {
|
|
i := 0 // ERROR "moved to heap: i$"
|
|
var x X
|
|
// BAD: &i should not escape
|
|
x.p1 = &i
|
|
var iface interface{} = x // ERROR "x does not escape"
|
|
y, _ := iface.(Y) // Put X, but extracted Y. The cast will fail, so y is zero initialized.
|
|
sink = y // ERROR "y escapes to heap"
|
|
}
|