mirror of
https://github.com/golang/go
synced 2024-11-23 15:20:03 -07:00
ec5b6406b7
Use "have" and "want" and multiple lines like other similar error messages. Also, fix handling of ... and multi-value function calls. Fixes #17650. Change-Id: I4850e79c080eac8df3b92a4accf9e470dff63c9a Reviewed-on: https://go-review.googlesource.com/32261 Reviewed-by: Robert Griesemer <gri@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
62 lines
1.5 KiB
Go
62 lines
1.5 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that illegal uses of ... are detected.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
import "unsafe"
|
|
|
|
func sum(args ...int) int { return 0 }
|
|
|
|
var (
|
|
_ = sum(1, 2, 3)
|
|
_ = sum()
|
|
_ = sum(1.0, 2.0)
|
|
_ = sum(1.5) // ERROR "integer"
|
|
_ = sum("hello") // ERROR ".hello. .type string. as type int|incompatible"
|
|
_ = sum([]int{1}) // ERROR "\[\]int literal.*as type int|incompatible"
|
|
)
|
|
|
|
func sum3(int, int, int) int { return 0 }
|
|
func tuple() (int, int, int) { return 1, 2, 3 }
|
|
|
|
var (
|
|
_ = sum(tuple())
|
|
_ = sum(tuple()...) // ERROR "multiple-value"
|
|
_ = sum3(tuple())
|
|
_ = sum3(tuple()...) // ERROR "multiple-value" "not enough"
|
|
)
|
|
|
|
type T []T
|
|
|
|
func funny(args ...T) int { return 0 }
|
|
|
|
var (
|
|
_ = funny(nil)
|
|
_ = funny(nil, nil)
|
|
_ = funny([]T{}) // ok because []T{} is a T; passes []T{[]T{}}
|
|
)
|
|
|
|
func bad(args ...int) {
|
|
print(1, 2, args...) // ERROR "[.][.][.]"
|
|
println(args...) // ERROR "[.][.][.]"
|
|
ch := make(chan int)
|
|
close(ch...) // ERROR "[.][.][.]"
|
|
_ = len(args...) // ERROR "[.][.][.]"
|
|
_ = new(int...) // ERROR "[.][.][.]"
|
|
n := 10
|
|
_ = make([]byte, n...) // ERROR "[.][.][.]"
|
|
// TODO(rsc): enable after gofmt bug is fixed
|
|
// _ = make([]byte, 10 ...) // error "[.][.][.]"
|
|
var x int
|
|
_ = unsafe.Pointer(&x...) // ERROR "[.][.][.]"
|
|
_ = unsafe.Sizeof(x...) // ERROR "[.][.][.]"
|
|
_ = [...]byte("foo") // ERROR "[.][.][.]"
|
|
_ = [...][...]int{{1,2,3},{4,5,6}} // ERROR "[.][.][.]"
|
|
}
|